From: Marius Bakke <mbakke@fastmail.com>
To: ng0 <ng0@we.make.ritual.n0.is>, guix-devel@gnu.org
Subject: Re: [PATCH] Add perl-digest-md5.
Date: Tue, 22 Nov 2016 20:55:57 +0100 [thread overview]
Message-ID: <87poln5lwy.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20161122135240.15557-1-ng0@we.make.ritual.n0.is>
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
ng0 <ng0@we.make.ritual.n0.is> writes:
> [PATCH] gnu: Add perl-digest-md5.
>
> This adds perl-digest-md5, in web.scm as perl-digest-md5-file is located there.
Hi! The patch looks good, but I think it should go in perl.scm. The
rationale for adding perl-digest-md5-file in web.scm seems to be that
it's a module for checksumming URIs, whereas this is a general-purpose
checksum program similar to e.g. 'perl-digest-sha1'.
Can you send an updated patch? Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]
next prev parent reply other threads:[~2016-11-22 19:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 13:52 [PATCH] Add perl-digest-md5 ng0
2016-11-22 13:52 ` [PATCH] gnu: " ng0
2016-11-22 19:55 ` Marius Bakke [this message]
2016-11-22 23:57 ` perl-digest-md5 , rev2 ng0
2016-11-22 23:57 ` [PATCH] gnu: Add perl-digest-md5 ng0
2016-11-23 15:55 ` perl-digest-md5 , rev2 Marius Bakke
2016-11-23 16:06 ` ng0
2016-11-23 16:10 ` Marius Bakke
2016-11-23 18:30 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87poln5lwy.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=guix-devel@gnu.org \
--cc=ng0@we.make.ritual.n0.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).