From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/2] gnu: idris: Update to 0.99.
Date: Mon, 19 Dec 2016 15:13:15 +0100
Message-ID: <87poko3t38.fsf@gnu.org>
References: <20161215172835.7300-1-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48694)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cIygs-0003QD-Dq
	for guix-devel@gnu.org; Mon, 19 Dec 2016 09:13:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cIygn-0004OT-HF
	for guix-devel@gnu.org; Mon, 19 Dec 2016 09:13:22 -0500
In-Reply-To: <20161215172835.7300-1-david@craven.ch> (David Craven's message
	of "Thu, 15 Dec 2016 18:28:34 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

Hi!

David Craven <david@craven.ch> skribis:

> * gnu/packages/haskell.scm (idris): Update to 0.99.

[...]

> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "IDRIS_LIBRARY_PATH")
> +            (files '("idris/libs")))))

The conventional thing would be to use =E2=80=9Clib/idris=E2=80=9D (just li=
ke we have
=E2=80=9Clib/perl5=E2=80=9D, =E2=80=9Clib/python2.7=E2=80=9D, =E2=80=9Clib/=
guile=E2=80=9D, etc.)  Could you make this
change?

I suppose it=E2=80=99s OK to make this change now since there are no Idris
libraries packaged yet.

> +++ b/gnu/packages/patches/idris-IDRIS_LIBRARY_PATH.patch
> @@ -0,0 +1,46 @@
> +From 8617ba8f391da875ea0d59c6b8fdce26b64e2abd Mon Sep 17 00:00:00 2001
> +From: David Craven <david@craven.ch>
> +Date: Sun, 6 Nov 2016 15:46:50 +0100
> +Subject: [PATCH 1/2] IDRIS_LIBRARY_PATH accepts a colon separated search=
 path.
> +
> +* src/Idris/Imports.hs (installedPackages): SplitOn colon and concatMap
> +  the results.

Could you indicate what the upstream status of this patch is?

If you haven=E2=80=99t done it yet, I encourage you to submit it upstream: =
it
looks like there=E2=80=99s no reason not to have it upstream.

Otherwise LGTM.

Thank you!

Ludo=E2=80=99.