From: Marius Bakke <mbakke@fastmail.com>
To: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: add geos
Date: Mon, 23 Jan 2017 17:59:52 +0100 [thread overview]
Message-ID: <87pojd67av.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20170123001251.1e2d7bef@alma-ubu>
[-- Attachment #1: Type: text/plain, Size: 1652 bytes --]
Björn Höfling <bjoern.hoefling@bjoernhoefling.de> writes:
> Thanks for accepting!
>
> I have some comments/questions below.
>
>> > + (arguments `(#:phases
>> > + (modify-phases %standard-phases
>> > + (add-after
>> > + 'unpack 'patch-test-shebangs
>> > + (lambda _
>> > + (substitute*
>> > '("tests/xmltester/testrunner.sh"
>> > +
>> > "tests/geostest/testrunner.sh")
>> > + (("/bin/sh") (which "bash")))
>>
>> Bash behaves differently based on whether it's invoked as 'bash' or
>> 'sh', so I changed this to (which "sh") to be safe.
>
> I thought I found that sh-> "bash" substitution quite often, for example here in nginx:
>
> http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/web.scm#n148
Thanks for catching that; fixed! :-)
It's something we've only recently started to take care of. Feel free to
submit patches!
>> > + (license license:lgpl2.1)))
>>
>> The files do not mention whether it's 2.1 only or later versions so we
>> default to "or later". Also found a few files with other licenses.
>
> I also found no mentioning of "later" or not, so I thought to stick with the
> mentioned license version. What makes you use the "or later" version?
This convention has been mentioned to me in passing a couple of times on
this mailing list. I'm not sure where it comes from, but often
double-check with Debians copyright information which settled on the
same license:
http://metadata.ftp-master.debian.org/changelogs/main/g/geos/geos_3.5.1-3_copyright
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
prev parent reply other threads:[~2017-01-23 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 17:35 [PATCH] gnu: add geos Björn Höfling
2017-01-21 13:08 ` Marius Bakke
2017-01-22 23:12 ` Björn Höfling
2017-01-23 16:59 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pojd67av.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=bjoern.hoefling@bjoernhoefling.de \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).