From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodoros Foradis Subject: Re: [PATCH 1/1] gnu: icestorm: Replace reference in icebox_vlog. Date: Fri, 10 Mar 2017 21:22:38 +0200 Message-ID: <87pohpq6m9.fsf@openmailbox.org> References: <20170114185652.29952-1-theodoros.for@openmailbox.org> <20170114185652.29952-2-theodoros.for@openmailbox.org> <20170114202524.0f056d54@scratchpost.org> <87tw8zs49o.fsf@openmailbox.org> <20170116152125.0f011148@scratchpost.org> <20170117205357.GB17056@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmQfG-0006cx-8L for guix-devel@gnu.org; Fri, 10 Mar 2017 14:57:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmQfB-0000JW-QZ for guix-devel@gnu.org; Fri, 10 Mar 2017 14:57:26 -0500 Received: from lb1.openmailbox.org ([5.79.108.160]:37549 helo=mail.openmailbox.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmQfB-0000JQ-Hn for guix-devel@gnu.org; Fri, 10 Mar 2017 14:57:21 -0500 In-reply-to: <20170117205357.GB17056@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel Leo Famulari writes: > On Mon, Jan 16, 2017 at 03:21:29PM +0100, Danny Milosavljevic wrote: >> Hi, >> >> > I should have probably added a different phase for the >> > "icebox/icebox_vlog.py" substitution, to make clear it's the only path >> > which is a run-time reference. The installed icebox_vlog, can't find the >> > chipdb.txt file, if we don't make the substitution. >> >> Yeah, I think how you did it now is best. >> >> LGTM! >> >> I've built it and it works. >> >> I'll leave some time for others to comment. Afterwards, I'll commit it >> to master (since it'll cause rebuild of one icestorm-dependent >> package). > > LGTM! Thanks Theodoros and Danny! Hello, Just a reminder for this patch, because I see that it has not been commited yet. Is there anything blocking it? Thanks, -- Theodoros Foradis