From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: 01/01: gnu: qemu: Enable Samba support.
Date: Wed, 27 Dec 2017 13:04:09 +0100
Message-ID: <87po704bt2.fsf@gnu.org>
References: <20171227092649.22335.79799@vcs0.savannah.gnu.org>
	<20171227092650.69D7B204F7@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48390)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1eUARg-0007fn-6T
	for guix-devel@gnu.org; Wed, 27 Dec 2017 07:04:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1eUARc-00068A-SP
	for guix-devel@gnu.org; Wed, 27 Dec 2017 07:04:28 -0500
Received: from [141.255.128.1] (port=39431 helo=hera.aquilenet.fr)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <ludo@gnu.org>) id 1eUARc-00066o-Mm
	for guix-devel@gnu.org; Wed, 27 Dec 2017 07:04:24 -0500
In-Reply-To: <20171227092650.69D7B204F7@vcs0.savannah.gnu.org> (Rutger
	Helling's message of "Wed, 27 Dec 2017 04:26:50 -0500 (EST)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org, Rutger Helling <rhelling@mykolab.com>

Hello,

rhelling@mykolab.com (Rutger Helling) skribis:

> commit 84276503059d46c0a42240f8770f59090614d863
> Author: Rutger Helling <rhelling@mykolab.com>
> Date:   Wed Dec 27 10:09:26 2017 +0100
>
>     gnu: qemu: Enable Samba support.
>=20=20=20=20=20
>     * gnu/packages/virtualization.scm (qemu)[arguments]: Change #:configu=
re-flags to
>     a list, add --smbd flag.
>     [inputs]: Add samba.

[...]

> +       #:configure-flags (list "--enable-usb-redir" "--enable-opengl"
> +                               (string-append "--smbd=3D"
> +                                              (assoc-ref %build-inputs "=
samba")
> +                                              "/sbin/smbd"))

For the record, we removed the dependency on Samba long ago (commit
b344c505f4dff2ecbe981f0a0a3c3d67b222dcca), largely because Samba is a
huge dependency:

--8<---------------cut here---------------start------------->8---
$ guix size qemu | tail -1
total: 817.4 MiB
$ guix size qemu samba | tail -1
total: 1176.0 MiB
--8<---------------cut here---------------end--------------->8---

As it stands I=E2=80=99d still be in favor of not having the default =E2=80=
=98qemu=E2=80=99
depend on Samba.

Perhaps one solution would be to change the =E2=80=98exec=E2=80=99 call tha=
t invokes
=E2=80=98smbd=E2=80=99 to =E2=80=98execlp=E2=80=99 (or similar) so that =E2=
=80=98smbd=E2=80=99 is search for in $PATH.
That way, if the user installs Samba, then support is available,
otherwise it=E2=80=99s missing.

WDYT?

Thanks,
Ludo=E2=80=99.