unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: guix-devel@gnu.org, Tobias Geerinckx-Rice <me@tobias.gr>
Subject: Re: 01/01: services: Add SRFI-26 to Nix activation gexp.
Date: Wed, 12 Jun 2019 14:06:13 +0200	[thread overview]
Message-ID: <87pnnjxb2i.fsf@gnu.org> (raw)
In-Reply-To: <20190611191006.B2385204DB@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Tue, 11 Jun 2019 15:10:06 -0400 (EDT)")

Hi Tobias,

guix-commits@gnu.org skribis:

> commit 2be6b5e2eea9ac084cc22281f64f7a089e46cdae
> Author: Tobias Geerinckx-Rice <me@tobias.gr>
> Date:   Tue Jun 11 20:50:37 2019 +0200
>
>     services: Add SRFI-26 to Nix activation gexp.

[...]

>  (define (nix-activation _)
>    "Return the activation gexp."
> -  (with-imported-modules '((guix build utils))
> +  (with-imported-modules '((guix build utils)
> +                           (srfi srfi-26))
>      #~(begin
> -        (use-modules (guix build utils))
> +        (use-modules (guix build utils)
> +                     (srfi srfi-26))

(srfi srfi-26) must not be added to the imported modules: it would
import it from the host Guile, but the host Guile version may differ
between users, and thus the resulting derivation would also differ.

The right thing is to just (use-modules (srfi srfi-26)), which has the
effect of using that module from the Guile being used for builds.

Could you adjust it accordingly?

Thanks, and thanks for the bug fix!

Ludo’.

       reply	other threads:[~2019-06-12 12:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190611191005.14930.97243@vcs0.savannah.gnu.org>
     [not found] ` <20190611191006.B2385204DB@vcs0.savannah.gnu.org>
2019-06-12 12:06   ` Ludovic Courtès [this message]
2019-06-12 16:08     ` 01/01: services: Add SRFI-26 to Nix activation gexp Tobias Geerinckx-Rice
2019-06-13  8:08       ` Ludovic Courtès
2019-06-12 17:32   ` Mark H Weaver
2019-06-12 17:54     ` Tobias Geerinckx-Rice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnnjxb2i.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).