From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: 01/02: build: gnu-build-system: Don't run configure during bootstrap. Date: Sun, 16 Feb 2020 17:34:13 +0100 Message-ID: <87pnee5w56.fsf@devup.no> References: <20200216072616.4957.58376@vcs0.savannah.gnu.org> <20200216072618.88AB021120@vcs0.savannah.gnu.org> <877e0m7gkn.fsf@devup.no> <20200216145517.GE1968@E5400> <20200216162422.GA5829@LionPure> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:45074) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3MsC-0007Bs-4v for guix-devel@gnu.org; Sun, 16 Feb 2020 11:34:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3Ms7-00071e-L6 for guix-devel@gnu.org; Sun, 16 Feb 2020 11:34:23 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:56865) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j3Ms7-00071M-7W for guix-devel@gnu.org; Sun, 16 Feb 2020 11:34:19 -0500 In-Reply-To: <20200216162422.GA5829@LionPure> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Bengt Richter , Efraim Flashner Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Bengt Richter writes: > Hi Efraim, > > On +2020-02-16 16:55:17 +0200, Efraim Flashner wrote: >> On Sun, Feb 16, 2020 at 03:27:36PM +0100, Marius Bakke wrote: >> > guix-commits@gnu.org writes: >> >=20 >> > > commit 481a0f1a7ceac666a011b28324220584ead07698 >> > > Author: Efraim Flashner >> > > AuthorDate: Thu Feb 13 10:54:29 2020 +0200 >> > > >> > > build: gnu-build-system: Don't run configure during bootstrap. >> > >=20=20=20=20=20 >> > > * guix/build/gnu-build-system.scm (bootstrap): Add NOCONFIGURE >> > > environment variable before running bootstrap scripts. >> >=20 >> > [...] >> >=20 >> > > @@ -190,6 +190,7 @@ working directory." >> > > (if (executable-file? script) >> > > (begin >> > > (patch-shebang script) >> > > + (setenv "NOCONFIGURE" "true") >> > > (invoke script)) >> > > (invoke "sh" script))) >> > > (if (or (file-exists? "configure.ac") >> >=20 >> > Should we unset NOCONFIGURE afterwards? Probably at least one package >> > uses this variable for something completely different... >>=20 >> It probably wouldn't hurt to unset it. I've never come across a package >> where that's been a problem but best not invite trouble. >> > With all due respect, I am not comfortable with this kind of rationale :)= =20 > > If it's never been a problem, unsetting might hide a case where it _would_ > cause a problem -- which IMO it would be better to find out about than no= t. I'm not sure I follow. The variable in question has only been used in a handful of packages[0]. Now we are adding it in nearly 10k packages. Why would we want to know whether a package build process has a problem with that particular variable? [0] https://git.savannah.gnu.org/cgit/guix.git/commit/?h=3Dcore-updates&id= =3D778d6b522ae361767d3cf984a3b182bac7361b7a --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl5JbwUACgkQoqBt8qM6 VPqQ7AgAmFzzQXzBhyFU1ZLRtTPZHvVdYRtRPRF6Mo2XlWgO380tDyZhj66dl38U vPPDFFWsZySzwN5TOtaKxZZ8ldjeIqXwWFmIYhK5XPKsEL4fi0cu9evxAp/QOuHI ZFTIGOdoa8ucVR3CSm8zXjAa//Ujyr/b9UKLRnfdduEkovxBsPN5JJnKkAZbtuv3 FY/0e/sfqzC2UyVYuCnzbpbnZm8qPKzQ5HKch6ivjHOPWEog/hcA26EvR+O9WVlK RBrn9NN5eT3eRjgkfptxCCvbauJo7Wuxe/nqQM84pJne7IzyrUrMLC0LO0FTyZJQ ePRlqgD9qnCzxPH1PLtiGi+gfZUhXg== =6Zsp -----END PGP SIGNATURE----- --=-=-=--