From: Marius Bakke <mbakke@fastmail.com>
To: Bengt Richter <bokr@bokr.com>, Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: 01/02: build: gnu-build-system: Don't run configure during bootstrap.
Date: Sun, 16 Feb 2020 17:34:13 +0100 [thread overview]
Message-ID: <87pnee5w56.fsf@devup.no> (raw)
In-Reply-To: <20200216162422.GA5829@LionPure>
[-- Attachment #1: Type: text/plain, Size: 1953 bytes --]
Bengt Richter <bokr@bokr.com> writes:
> Hi Efraim,
>
> On +2020-02-16 16:55:17 +0200, Efraim Flashner wrote:
>> On Sun, Feb 16, 2020 at 03:27:36PM +0100, Marius Bakke wrote:
>> > guix-commits@gnu.org writes:
>> >
>> > > commit 481a0f1a7ceac666a011b28324220584ead07698
>> > > Author: Efraim Flashner <efraim@flashner.co.il>
>> > > AuthorDate: Thu Feb 13 10:54:29 2020 +0200
>> > >
>> > > build: gnu-build-system: Don't run configure during bootstrap.
>> > >
>> > > * guix/build/gnu-build-system.scm (bootstrap): Add NOCONFIGURE
>> > > environment variable before running bootstrap scripts.
>> >
>> > [...]
>> >
>> > > @@ -190,6 +190,7 @@ working directory."
>> > > (if (executable-file? script)
>> > > (begin
>> > > (patch-shebang script)
>> > > + (setenv "NOCONFIGURE" "true")
>> > > (invoke script))
>> > > (invoke "sh" script)))
>> > > (if (or (file-exists? "configure.ac")
>> >
>> > Should we unset NOCONFIGURE afterwards? Probably at least one package
>> > uses this variable for something completely different...
>>
>> It probably wouldn't hurt to unset it. I've never come across a package
>> where that's been a problem but best not invite trouble.
>>
> With all due respect, I am not comfortable with this kind of rationale :)
>
> If it's never been a problem, unsetting might hide a case where it _would_
> cause a problem -- which IMO it would be better to find out about than not.
I'm not sure I follow. The variable in question has only been used in a
handful of packages[0]. Now we are adding it in nearly 10k packages.
Why would we want to know whether a package build process has a problem
with that particular variable?
[0] https://git.savannah.gnu.org/cgit/guix.git/commit/?h=core-updates&id=778d6b522ae361767d3cf984a3b182bac7361b7a
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-02-16 16:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200216072616.4957.58376@vcs0.savannah.gnu.org>
[not found] ` <20200216072618.88AB021120@vcs0.savannah.gnu.org>
2020-02-16 14:27 ` 01/02: build: gnu-build-system: Don't run configure during bootstrap Marius Bakke
2020-02-16 14:55 ` Efraim Flashner
2020-02-16 16:24 ` Bengt Richter
2020-02-16 16:34 ` Marius Bakke [this message]
2020-02-16 17:18 ` Bengt Richter
2020-02-18 17:38 ` Marius Bakke
2020-02-16 16:48 ` Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnee5w56.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=bokr@bokr.com \
--cc=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).