From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yO55M7KGqWLUbgAAbAwnHQ (envelope-from ) for ; Wed, 15 Jun 2022 09:13:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 4PWSMrKGqWItVAAAG6o9tA (envelope-from ) for ; Wed, 15 Jun 2022 09:13:54 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 73E6D17F94 for ; Wed, 15 Jun 2022 09:13:54 +0200 (CEST) Received: from localhost ([::1]:32790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1MyM-0006EG-On for larch@yhetil.org; Wed, 15 Jun 2022 02:57:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1Mnm-0001Ze-9h for guix-devel@gnu.org; Wed, 15 Jun 2022 02:46:59 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:34136) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1Mnh-0007Ox-VG; Wed, 15 Jun 2022 02:46:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JR6a5y+xGqHvZblPUgtZEMfpt8CjrSZkS6M8Dp0tY+w=; b=UT2a8o1OUvZV2wBBOMmfzc+pjC 8QvXCEa0ctwbtNvVDvfOPvm816PnGxbd7ymv4Sap/ivRDtPZFz5TM5KWELsVTjgvKykl6h1UJgN5/ RBurq2VZ3uyiWdC8WFTDv+jaoDaW5DUe+yRvN4o9k8DGPo/hFS8Mg0V3g0OqlFz2n12h917RF+E6I CkrL6svg2Onw7hBO/TJ7NoyL7pWOvKJaTeQcYsfQ2YVVotso1h043U86MiU0DdJfm/BlQueal5e/6 nitdeHooviBjX80jyJG1ppk/fBq+x3Qp0gpYlnBVRPm9pfvxO+jdnulo0XOI0f8mPuqNcbEyxQKGN cA/4mjfQ==; Received: from [192.168.2.1] (port=5094 helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1o1MnQ-000BiM-IT; Wed, 15 Jun 2022 12:16:32 +0530 From: Arun Isaac To: Maxim Cournoyer , zimoun Cc: Thiago Jung Bauermann , Giovanni Biscuolo , GNU Guix maintainers , guix-devel@gnu.org Subject: Re: On commit access, patch review, and remaining healthy In-Reply-To: <87fsk7fdft.fsf@gmail.com> References: <87ee07m77w.fsf@gnu.org> <877d5um1oe.fsf@systemreboot.net> <87tu8viix0.fsf@xelera.eu> <87bkv1lipm.fsf@systemreboot.net> <87o7z0itz3.fsf@xelera.eu> <8735gb4xry.fsf@kolabnow.com> <86ilp3cvf8.fsf@gmail.com> <87fsk7fdft.fsf@gmail.com> Date: Wed, 15 Jun 2022 12:16:32 +0530 Message-ID: <87pmja2zlj.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=139.59.75.54; envelope-from=arunisaac@systemreboot.net; helo=mugam.systemreboot.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655277234; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JR6a5y+xGqHvZblPUgtZEMfpt8CjrSZkS6M8Dp0tY+w=; b=A7maW6puz8lHKgTEKh0nFPJjLTks+pwS4N0CfO+7B5eyZ7ZRkslj/rbX5MbRNRg10ndqCz /Ok6HOFKiQTk/xgqwj6mHCJFucN6/mFnaYWyIb2jxglilze13b1Vveycwqc7SYg78QQ+qH Z2FDpUWZkDigbvsQsKRCZF/YTaD+7+mMLNrDjH5iigKEQamSoeXbeBlvL/iyhlsUaYRaAo L/wRShT1NMP2v1SNDlryNQjkjSLqCxDjwwxUzq4XWzyenagDsBu03De1pibWqon3QL9Sx0 DaC+jLekqsMgaLDlZuCKBIl0GgnrW9sHuzB1CcGQ0eXbGbzM+OOwH4sah+Ik3g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655277234; a=rsa-sha256; cv=none; b=JrfDwguVloF8NYIrMbhrHbA3fUB4AsEJ6rf1WzzRSZfH+uSx6x3L8sHTaBdYcZNDqbZoeO nqbmZyYj2W99PF4s1ANmZztaJkaHU24HonWOSWharRzQwkMNjBleu5FFEdocS0UsCtzr4Q GXM+fKwJ3EQtv4bq3DSLUyZOyQszfm15KCKCyD5z7ee/fOK3p/osu+tfeBkaQBZsBPk+Ar ldIEcZHddhXDLmi3gAoQM8kVFmM/7uFbLFQrs0hLkRP50tdf8aGnTvVAsT2w+nmqyB321A pxTwmGYq3V5PlLbdKYVexHx8kADFnudUr51qXxeUhArxJOWv2WTStPS3/YUlCA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=UT2a8o1O; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.71 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=UT2a8o1O; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 73E6D17F94 X-Spam-Score: 7.71 X-Migadu-Scanner: scn1.migadu.com X-TUID: eCZDXIqw1G6g >>> Personally, I think nowadays this purpose is better fulfilled by >>> good commit messages and git blame. Especially with an editor that makes >>> it easy to use them to navigate through history (such as Emacs, but >>> certainly others as well). >> >> Because these standards, it is easy to navigate via grep for instance. >> Git blame is useful once you know exactly what you are looking for. >> Before that, when I try to figure out the logic behind such change, the >> commit messages more or less fixed by the standards are very helpful, >> IMHO. > > I agree. I've come to like GNU ChangeLog commit messages because it > forces me to lay down the changes I've worked on, and sometimes I can > spot things that would be better separated in its own commit, or that > was unintentionally left while testing. Exactly! I too have grown to like our ChangeLog style commit messages enough that I use it in my own repositories. I like to think of them as akin to the Pointing and Calling[1] system common on Japanese railways. In the Pointing and Calling system, the railway worker has to not only go through a checklist of items, but also has to actually *point* (gesturing) and *call" (verbalizing) the relevant dial or traffic signal. This explicit gesturing and verbalizing makes them pay more attention and reduces the probability of an accident. Likewise, our ChangeLog style commit messages force the committer to explicitly list down the changes and thus catch any lapses of concentration. [1]: https://en.wikipedia.org/wiki/Pointing_and_calling > When reviewing others' work it also give me a clear trail of what they > did, and I can match the actual changes to their high level > description. I agree! :-)