From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: Should commit signing always be required for local work? [was Re: bug#63261: Recent changes to git config cause errors for non-committers]
Date: Thu, 18 May 2023 23:24:23 -0400 [thread overview]
Message-ID: <87pm6xknq0.fsf@gmail.com> (raw)
In-Reply-To: <ZGZZasQdiWIF/B32@jasmine.lan> (Leo Famulari's message of "Thu, 18 May 2023 12:59:22 -0400")
Hi Leo,
Leo Famulari <leo@famulari.name> writes:
> On Mon, May 15, 2023 at 09:38:33AM -0400, Maxim Cournoyer wrote:
>> Hi Leo,
>>
>> Leo Famulari <leo@famulari.name> writes:
>>
>> > Can someone help me by pointing to the original discussion of this
>> > change?
>>
>> It was the team.scm issue in https://issues.guix.gnu.org/58813 that led
>> to this change.
>
> Thanks for pointing it out.
>
> In my opinion, this change should be discussed more publicly so that a
> consensus can be reached about it.
>
> This change affects the workflow of everyone that hacks on Guix,
> including people who are trying it for the very first time.
>
> It's a big change.
>
> It's not okay to only discuss such a big change in a ticket with the
> title "can't substitute etc/teams.scm command as doc suggests".
>
> I am asking for this to be reverted until a consensus is reached.
Thanks for voicing your thoughts on this. I originally thought the
included fragments (via the 'include.path' git config option) could we
overridden by a user but it seems they can't, making the change more
intrusive than it should have been.
I've reverted just the offending bits:
--8<---------------cut here---------------start------------->8---
diff --git a/etc/git/gitconfig b/etc/git/gitconfig
index 831fbce6e7..907ad01804 100644
--- a/etc/git/gitconfig
+++ b/etc/git/gitconfig
@@ -1,6 +1,3 @@
-[commit]
- gpgsign = true
-
[diff "scheme"]
xfuncname = "^(\\(define.*)$"
--8<---------------cut here---------------end--------------->8---
Let me know if something is amiss.
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-05-19 3:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <874jospdr2.fsf@psyduck.jhoto.kublai.com>
[not found] ` <87y1m024rx.fsf@gmail.com>
[not found] ` <ZF/fCxinkPg9lJNc@jasmine.lan>
[not found] ` <875y8tww86.fsf@gmail.com>
2023-05-18 16:59 ` Should commit signing always be required for local work? [was Re: bug#63261: Recent changes to git config cause errors for non-committers] Leo Famulari
2023-05-19 3:24 ` Maxim Cournoyer [this message]
2023-05-19 9:34 ` Josselin Poiret
2023-05-19 16:22 ` Simon Tournier
2023-05-24 21:00 ` Vagrant Cascadian
2023-05-24 21:17 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-05-24 22:02 ` Vagrant Cascadian
2023-05-26 17:54 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm6xknq0.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).