From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SOt4NTKM+2QfwgAAG6o9tA:P1 (envelope-from ) for ; Fri, 08 Sep 2023 23:03:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id SOt4NTKM+2QfwgAAG6o9tA (envelope-from ) for ; Fri, 08 Sep 2023 23:03:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0AFD1C063 for ; Fri, 8 Sep 2023 23:03:46 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=cnfdoc0f; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694207026; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=8mPHj0JdMwBU0i+ee2XrEJspAS5VbvNkSnW9p7pqiGg=; b=mZH6id8oNlfdHnMRpH9I3GGNzDJll5iv0vkxbLnTnGzV4W92nfDtxFng8T4ea71OTWWhPO 71ytcfAgre6O8PKjL6BLNSF4FlFq0kWqmmfDlrl0+YbMkIhqHDJV2+189u0ik7CvBtZv8R ytAHFX56kypffm0p1/P2FiTKEbwUIFqUVomLz+vmsio1Xda5S/V4xKCzibsWbmtkxbzO2i 0uwTMjbhckyn/o/mKChlWGHSvNAwfDm0N4188XYMqgaD8XYfVfm/meHi0xDpqTI4iaWbzG pIZAWHlIhObVFKT/4haho0I8OpicTTZI+JnXgawIV75ccHzVCU9PgcCtCSo0CQ== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1694207026; a=rsa-sha256; cv=pass; b=UXgX6NGagn/pzts6OIW2l8MnBYQ2aly42IpqvV2AdehjXCleNzBbnc23iviiaFXqrf3ywB lKg8ZgM4D8UOKRSvrSe9wF05JYe52nkOE4RPqVvf6avANgWw5O2VxGh+Yvn8uW/T2qIrQl /rPFMfrejD8C+4fUJ0oUCj6fBwCR+zk1j8nmjBNlEfq60+y0j0w2714V5rWBstb0pAab4z pTpbzs/PrSoAmq5nRv7yomXsZnydFEohrE27j/Ia3MZuJl5OWYiUxZwwPL06/Jdg/jqnrX +5Li9NDTriWsEHevU6q4AMCjh6zcHncfDrEa73c8qCRjzEPdjOeEMD8dcjtacg== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=cnfdoc0f; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1") Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeiLr-0002us-4U; Fri, 08 Sep 2023 16:45:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeiLm-0002uY-Hf for guix-devel@gnu.org; Fri, 08 Sep 2023 16:45:13 -0400 Received: from sender3-of-o59.zoho.com ([136.143.184.59]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeiLh-0004do-W8 for guix-devel@gnu.org; Fri, 08 Sep 2023 16:45:09 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1694205900; cv=none; d=zohomail.com; s=zohoarc; b=bAKKTwiEeWh/FocQPRSswN7Bw2fl5uakgaJyrV3bNC24guqs3n7E0fRJ3qgph4K9CFL49lq7x956/1srNtcKUx22ZZ1q8S4FS5oYPqOSGZmlTTlqYzRJv6ltblVdklEDD3fV5W2KmRB4tn1XKqkE62NTpm+XWpkGNnNWVrJbbiI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694205900; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=8mPHj0JdMwBU0i+ee2XrEJspAS5VbvNkSnW9p7pqiGg=; b=VBHMwIGyNdp0PR22Quyx9DgWIkXgWKyN5KUP+MUOPKsSo1utBt5Ht8e2YgYLpVbS05LIN3l7MlTT2hTnIppaTSdRg08bqeKw3eu1z6/PjUPvWg/BLDzoiNMVOMWYyxYO435kzaraimiz2PXUyzyCRBjjEuCCEoRYkl6b6CWJDiE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1694205900; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=8mPHj0JdMwBU0i+ee2XrEJspAS5VbvNkSnW9p7pqiGg=; b=cnfdoc0fhZnb6nhY6zy1VtQ1u0X9JS2VVsZReqgG5cuKepSHDR6s4vTccTJCXpUJ tyDA0YXe370S29r7SU3RdOAP0F47oFfO+MDPjVkjex5ICJnQmtoLrql4/45Jvvayy99 KchPlwqI4/87oo48SazRc4+EJ2xYtzn0WlUgyq7I= Received: from localhost (133-122-142-46.pool.kielnet.net [46.142.122.133]) by mx.zohomail.com with SMTPS id 1694205899130638.7106349081513; Fri, 8 Sep 2023 13:44:59 -0700 (PDT) References: <20230827135726.y33t55w4cvq6zsvb@X-kone> <874jkift8v.fsf@gmail.com> <87o7ic65ox.fsf@elephly.net> <6f11e4376690f35593a44f77cd9c7e40f3af8c06.camel@gmail.com> User-agent: mu4e 1.10.5; emacs 28.2 From: Ricardo Wurmus To: Liliana Marie Prikler Cc: Maxim Cournoyer , Saku Laesvuori , Attila Lendvai , Andreas Enge , Katherine Cox-Buday , guix-devel@gnu.org Subject: Re: How can we decrease the cognitive overhead for contributors? Date: Fri, 08 Sep 2023 22:37:02 +0200 In-reply-to: <6f11e4376690f35593a44f77cd9c7e40f3af8c06.camel@gmail.com> Message-ID: <87pm2s4cop.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.184.59; envelope-from=rekado@elephly.net; helo=sender3-of-o59.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -0.61 X-Spam-Score: -0.61 X-Migadu-Queue-Id: 0AFD1C063 X-TUID: c/6muCXXbOdl Liliana Marie Prikler writes: > Am Freitag, dem 08.09.2023 um 17:27 +0200 schrieb Ricardo Wurmus: >> I have the same positive view on our faux ChangeLogs commit messages, >> though I also would like to have them generated.=C2=A0 The benefit is >> still there: I still get to *review* an effective summary of the >> changes before pushing or sending them off for review.=C2=A0 But at least >> I don=E2=80=99t have to write them myself. >>=20 >> Now, this is no longer a problem for me because I=E2=80=99ve been writin= g so >> many commit messages over the years (and because I no longer try to >> adhere to some poorly specified format), but it *is* a problem for >> people that I=E2=80=99ve mentored. >>=20 >> etc/committer.scm and the yasnippets are supposed to alleviate some >> of the pain, but I don=E2=80=99t need to think for a long time to come up >> with a number of improvements in this area. > Can I assume this to mean it'd take you some short time to think of > snippets that we're currently lacking? If so, please do contribute > them. If not, what do you mean then? I mean that they have plenty of defects. When I wrote the first few iterations of etc/committer.scm it was only really meant and good for bulk package updates (=3D lots of changes across files, all upgrades). It couldn=E2=80=99t (and maybe still can=E2=80=99t) = reliably detect added or removed package definitions. It doesn=E2=80=99t handle cha= nges to the arguments field. It=E2=80=99s also terribly slow because it naively recomputes information for every hunk in the diff, reading package definitions from the old vs the changed file after every commit. The update yasnippet repeatedly gets the order of lines wrong when adding a patch to dist_patch_DATA in gnu/local.mk; it also doesn=E2=80=99t = do what etc/committer.scm is already able to do: detecting changes to inputs. Configuring yasnippet is also not trivial for people who don=E2=80= =99t regularly use Emacs (the snippets are tied to modes set by magit). I think in light of these defects =E2=80=9CUhm, we have snippets?=E2=80=9D = isn=E2=80=99t a satisfying response. --=20 Ricardo