From: Simon Tournier <zimon.toutoune@gmail.com>
To: Greg Hogan <code@greghogan.com>, guix-devel <guix-devel@gnu.org>
Subject: Re: Helping with abandoned patches
Date: Fri, 08 Mar 2024 18:51:26 +0100 [thread overview]
Message-ID: <87plw47gtd.fsf@gmail.com> (raw)
In-Reply-To: <CA+3U0Z=VRV_YJeGUom=VCTZnPyyK7Gwum4ET0vs4jUYQkK2YwQ@mail.gmail.com>
Hi Greg,
On mer., 17 janv. 2024 at 12:17, Greg Hogan <code@greghogan.com> wrote:
> What is the preferred process for when a patch review is provided
> (often by a committer) but no response is received from the submitter
> (for many weeks or months)?
>
> Is it appropriate to make the recommended changes and submit an updated patch?
Yes because the aim is to improve the code so the review is not lost.
Moreover, in that case of no response after a delay, if the reviewer
does not have commit access, the best (more helpful) seems sending by
the reviewer or anyone else a new version including the recommended
changes.
Cheers,
simon
prev parent reply other threads:[~2024-03-11 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 17:17 Helping with abandoned patches Greg Hogan
2024-01-17 18:08 ` Saku Laesvuori
2024-01-17 18:10 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2024-03-08 17:51 ` Simon Tournier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plw47gtd.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=code@greghogan.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).