From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Python-build-system does not honour phases Date: Tue, 10 Sep 2013 23:20:16 +0200 Message-ID: <87ob8074rz.fsf@gnu.org> References: <20130907222607.GA28990@debian> <87hadtfzk4.fsf@gnu.org> <20130910082655.GA8621@debian> <20130910132836.GA4248@debian> <87k3iobm2o.fsf@gnu.org> <20130910190717.GA8670@debian> <20130910192725.GA9186@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:32807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJVR9-0003Sz-Ac for guix-devel@gnu.org; Tue, 10 Sep 2013 17:25:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJVR0-0002OD-Ik for guix-devel@gnu.org; Tue, 10 Sep 2013 17:25:27 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:47853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJVR0-0002O3-C7 for guix-devel@gnu.org; Tue, 10 Sep 2013 17:25:18 -0400 In-Reply-To: <20130910192725.GA9186@debian> (Andreas Enge's message of "Tue, 10 Sep 2013 21:27:25 +0200") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org Andreas Enge skribis: > We need to factor this out. I suggest to do the following: > In the install phase, before running setup.py, we create the directory and > add it to the python path. But this would only be needed for programs cre= ating > modules, and I suppose not for programs that only create executables. > > I see two solutions: > - We create the directory anyway, and try to remove it after installation= with > "rmdir -p". > - Or more cleanly, we can add a variable #:module? (default: #f) and crea= te > the directory only if this variable is set to #t. > > What do you think? It think it=E2=80=99s OK to create it anyway, and not even try to remove it, because packages that use =E2=80=98python-build-system=E2=80=99 surely have= Python modules to install, no? Ludo=E2=80=99.