From: ludo@gnu.org (Ludovic Courtès)
To: ggrant@riseup.net
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: add libglade
Date: Fri, 28 Feb 2014 21:09:41 +0100 [thread overview]
Message-ID: <87ob1ryp6i.fsf@gnu.org> (raw)
In-Reply-To: <38aed3a0611cb51be3edf81cbbef1677.squirrel@fruiteater.riseup.net> (ggrant@riseup.net's message of "Thu, 27 Feb 2014 15:56:07 -0800")
ggrant@riseup.net skribis:
> Hoping to gradually get back into packaging some stuff of interest. Here's
> libglade for now, if anything looks wrong be sure to let me know. :^)
OK, so here’s a proper review, on the assumption that it’s needed.
> From 58b053edfabd89b5c9da034b295791ceb1cf1281 Mon Sep 17 00:00:00 2001
> From: Guy Grant <ggrant@riseup.net>
> Date: Thu, 27 Feb 2014 17:46:06 -0600
> Subject: [PATCH] gnu: Add libglade
Please add a proper commit log.
> +(define-public libglade
> + (package
> + (name "libglade")
> + (version "2.6.4")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://ftp.gnome.org/pub/GNOME/sources/libglade/2.6/libglade-"
> + version
> + ".tar.gz"))
Use mirror://gnome.
> + (synopsis "Allows you to load glade interface files in a program at runtime")
Rather something like “Load GTK+2 Glade interface files at run time”, WDYT?
> + (description
> + "Libglade is a library that provides interfaces for loading graphical interfaces
> +described in glade xml files and for accessing the widgets built in the loading process,
> +.glade files are generated by the Glade application.")
> + (license license:lgpl2.0)))
I guess it’s v2.0-or-any-later-version, no? (Or even 2.1.) Could you
check that? If that is the case, then use license:lgpl2.0+.
Could you send an updated patch?
Thanks!
Ludo’.
prev parent reply other threads:[~2014-02-28 20:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 23:56 [PATCH] gnu: add libglade ggrant
2014-02-28 11:15 ` Ludovic Courtès
2014-02-28 17:49 ` ggrant
2014-02-28 20:09 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob1ryp6i.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=ggrant@riseup.net \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).