From: Mark H Weaver <mhw@netris.org>
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] list-packages: Display package usage count.
Date: Sun, 26 Oct 2014 15:46:30 -0400 [thread overview]
Message-ID: <87oasy1und.fsf@netris.org> (raw)
In-Reply-To: <87lho2y9km.fsf@gmail.com> (Eric Bavier's message of "Sun, 26 Oct 2014 13:23:05 -0500")
Eric Bavier <ericbavier@gmail.com> writes:
> Ludovic Courtès writes:
>
>> Eric Bavier <ericbavier@gmail.com> skribis:
>>
>>> + (define (users package)
>>> + (let ((n (length (package-transitive-dependents
>>> + (find-packages-by-name* (package-name package)
>>> + (package-version package))))))
>>
>> Why not just (package-transitive-dependents package)?
>
> Because that would not accurately count the "true" number of dependents.
Agreed, but what you wrote doesn't fully address the problem either.
If we modify 'gnu-make', that's also going to affect 'gnu-make-boot0' in
commencement.scm. Since that one has a different name ("make-boot0"),
your logic won't catch it.
Similarly, if you modify 'gcc-4.7', that's also going to affect
'gcc-4.8' (different version) which affects 'gcc-boot0' (with a
different name and version).
So, it seems to me that we need a way to find all packages that
'inherit' from the package we're changing, transitively. I'm not sure
off-hand if that information is preserved, but if not, we should
probably arrange to preserve it somehow.
Mark
next prev parent reply other threads:[~2014-10-26 19:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 17:15 [PATCH] list-packages: Display package usage count Eric Bavier
2014-10-25 21:47 ` Ludovic Courtès
2014-10-26 18:23 ` Eric Bavier
2014-10-26 19:46 ` Mark H Weaver [this message]
2014-10-26 20:22 ` Eric Bavier
2014-10-26 21:17 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oasy1und.fsf@netris.org \
--to=mhw@netris.org \
--cc=ericbavier@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).