From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: gobject-introspection typelibs and shared libraries Date: Mon, 08 Dec 2014 21:37:36 +0100 Message-ID: <87oardq3n3.fsf@gnu.org> References: <87ppbvkwzj.fsf@gnu.org> <87k322cx77.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xy53v-0004fc-SW for guix-devel@gnu.org; Mon, 08 Dec 2014 15:37:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xy53r-0001Tt-6u for guix-devel@gnu.org; Mon, 08 Dec 2014 15:37:43 -0500 Received: from hera.aquilenet.fr ([2a01:474::1]:51421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xy53q-0001Tp-Vm for guix-devel@gnu.org; Mon, 08 Dec 2014 15:37:39 -0500 In-Reply-To: (Federico Beffa's message of "Mon, 8 Dec 2014 13:21:20 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Federico Beffa Cc: Guix-devel Federico Beffa skribis: > On Mon, Dec 8, 2014 at 10:22 AM, Ludovic Court=C3=A8s wrot= e: >> Yes, I see in the diagram on the page above that libraries are actually >> dlopened, with the name that appears in the typelib file. >> >> Thus the patch you proposed is the right thing, I think. Before >> committing, could you add a comment a the top of the file explaining >> that the file names contained in typelib files are meant to be dlopen=E2= =80=99d, >> hence this patch? Also please credit the original author of the patch. > > Actually, I see that this part of gobject-introspection was slightly > edited from our version 1.38.0 to later ones. Nix uses 1.40.0 and the > newest is 1.42.0. So I'm planning to upgrade to the latest. Good. >>> Do we also need to do something for GI_TYPELIB_PATH? Perhaps this >>> should be in the =E2=80=98native-search-paths=E2=80=99 field of gobject= -introspection? >> >> I think that we do not need to set GI_TYPELIB_PATH in >> gobject-introspection, but in in the packages making use of it. > > I've run the tests with and without > > (native-search-paths > (list (search-path-specification > (variable "GI_TYPELIB_PATH") > (directories '("lib/girepository-1.0"))))) > (search-paths native-search-paths) You added these fields to =E2=80=98gobject-introspection=E2=80=99 itself, r= ight? That=E2=80=99s where it belongs. > (and with/without (search-path ...), but it makes no difference. This > probably due to the fact that there is no lib/girepository-1.0 > directory in the source tree and the tests are run before > installation. This will only make a difference when building packages that depend on gobject-introspection, and that also depend on packages having a lib/girepository-1.0 sub-directory. (Compare to how CPATH is handled for GCC.) > I therefore think that this is not needed here. It will be needed > with packages making use of gobject-introspection or other libraries > providing typelib files. Exactly. So it=E2=80=99s better to push a patch that adds it right after t= he patch that fixes g-ir-scanner. Thanks, Ludo=E2=80=99.