From: taylanbayirli@gmail.com (Taylan Ulrich Bayırlı/Kammer)
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add libsbsms.
Date: Wed, 25 Feb 2015 00:23:57 +0100 [thread overview]
Message-ID: <87oaoi7v1u.fsf@taylan.uni.cx> (raw)
In-Reply-To: <87fv9u9b1x.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 24 Feb 2015 23:52:58 +0100")
ludo@gnu.org (Ludovic Courtès) writes:
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + ;; Originally a symlink to '/usr/local/share/automake-1.12/ar-lib'.
>> + (delete-file "ar-lib")
>> + (symlink
>> + (string-append (assoc-ref inputs "automake") "/share/automake-"
>> + ,(package-version automake) "/ar-lib")
>> + "ar-lib"))
>
> I think it could just run “automake --add-missing” instead, which is
> lightly more elegant and future-proof.
That seems to lead to:
configure.ac:119: error: version mismatch. This is Automake 1.15,
configure.ac:119: but the definition used by this AM_INIT_AUTOMAKE
configure.ac:119: comes from Automake 1.12. You should recreate
configure.ac:119: aclocal.m4 with aclocal and run automake again.
configure.ac:119: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged.
configure.ac:119: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
configure.ac:119: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.
configure.ac:39: installing './ar-lib'
It works if I just run 'autoreconf -vif'. Is that fine?
I have to additionally add autoconf and libtool as inputs for that by
the way.
The final result would be:
(arguments
`(#:phases
;; Do this right after unpack because there's a danling symlink to
;; '/usr/local/share/automake-1.12/ar-lib' which causes a "no such
;; file or directory" during shebang patching.
(alist-cons-after
'unpack 'autoreconf
(lambda* (#:key inputs #:allow-other-keys)
(zero? (system* "autoreconf" "-vif")))
%standard-phases)))
Taylan
next prev parent reply other threads:[~2015-02-24 23:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-21 23:19 [PATCH] gnu: Add libsbsms Taylan Ulrich Bayırlı/Kammer
2015-02-21 23:22 ` Taylan Ulrich Bayırlı/Kammer
2015-02-24 17:32 ` Taylan Ulrich Bayırlı/Kammer
2015-02-24 22:52 ` Ludovic Courtès
2015-02-24 23:23 ` Taylan Ulrich Bayırlı/Kammer [this message]
2015-02-25 14:03 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oaoi7v1u.fsf@taylan.uni.cx \
--to=taylanbayirli@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).