From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul van der Walt Subject: Re: [PATCH] Update ncmpcpp to v0.6.2 Date: Fri, 27 Feb 2015 17:27:54 +0100 Message-ID: <87oaofiak5.fsf@denknerd.org> References: <87sidrll19.fsf@denknerd.org> <87vbin8qo2.fsf@fsf.org> <87lhjj72p3.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRNli-0000js-Md for guix-devel@gnu.org; Fri, 27 Feb 2015 11:28:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRNle-0000q2-FK for guix-devel@gnu.org; Fri, 27 Feb 2015 11:28:02 -0500 Received: from mx02.posteo.de ([89.146.194.165]:58307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRNle-0000pr-9M for guix-devel@gnu.org; Fri, 27 Feb 2015 11:27:58 -0500 In-reply-to: <87lhjj72p3.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: Guix-devel Hi, I'm a little busy for now, but i'll get to this soon. Thanks for your comments! On 2015-02-27 at 17:13, quoth Mark H Weaver: >> Paul van der Walt writes: > [...] >>> + (arguments >>> + '(#:configure-flags >>> + '("BOOST_LIB_SUFFIX=") >>> + #:phases >>> + (alist-cons-after >>> + 'unpack 'autogen >>> + (lambda _ >>> + (substitute* "autogen.sh" >>> + (("/bin/sh") (which "bash"))) >> >> Is "autogen.sh" not executable? If it starts with a shebang, Guix >> should patch the file appropriately. > > The problem here is that this 'autogen' phase is run before the > 'patch-source-shebangs' phase, at my suggestion. It has to be that way, > because 'patch-source-shebangs' (and 'patch-usr-bin-file') will need to > be run on the files created by 'autogen.sh'. This is the case. Is this therefore the cleanest way to do it? >>> + (setenv "NOCONFIGURE" "true") >>> + (zero? (system* "bash" "autogen.sh"))) >> >> If its executable, you can say: >> >> (zero? (system* "./autogen.sh")) > > Yes, after the 'substitute*' above, this should presumably work. My > guess is that Paul added the "bash" here before he realized that he > also needed the 'substitute*'. This is what happened. I'll modify that. One last question: >> From e1382a9df3e7df94e794df8aa247920b7e28c0c6 Mon Sep 17 00:00:00 2001 >> From: Paul van der Walt >> ... > > Could you please add a copyright line for yourself at the top of this > file? Are these from lines not enough? My previous patch which i generated the same way was accepted. Bye! Have good weekends! p.