From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add cutadapt.
Date: Tue, 24 Mar 2015 22:00:19 +0100
Message-ID: <87oaniyuu4.fsf@gnu.org>
References: <idjh9tfd7e9.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40982)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YaVw2-00029O-Rn
	for guix-devel@gnu.org; Tue, 24 Mar 2015 17:00:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YaVvz-0003gb-M4
	for guix-devel@gnu.org; Tue, 24 Mar 2015 17:00:26 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46481)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YaVvz-0003gL-Ia
	for guix-devel@gnu.org; Tue, 24 Mar 2015 17:00:23 -0400
In-Reply-To: <idjh9tfd7e9.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Fri, 20 Mar 2015 16:18:38 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> From 18a14112b6e22248638d2b34e1c1b935e1bcd343 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Fri, 20 Mar 2015 16:17:55 +0100
> Subject: [PATCH] gnu: Add cutadapt.
>
> * gnu/packages/bioinformatics.scm (cutadapt): New variable.

[...]

> +                   (setenv "PYTHONPATH"
> +                           (string-append
> +                            (getenv "PYTHONPATH")
> +                            ":" (assoc-ref outputs "out")
> +                            "/lib/python"
> +                            ,(version-major+minor (package-version pytho=
n))
> +                            "/site-packages"))

It=E2=80=99s best to check the Python version on the build side, using some=
thing
like =E2=80=98get-python-version=E2=80=99 from python-build-system.scm (so =
that if
someone inherits this package and changes the Python that is used it
still works.)

Other than that LGTM!

Ludo=E2=80=99.