From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 3/5] build: Add 'emacs-build-system' Date: Thu, 09 Jul 2015 11:51:38 +0300 Message-ID: <87oajlemsl.fsf@gmail.com> References: <87pp43j45o.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZD7YW-0001y9-SR for guix-devel@gnu.org; Thu, 09 Jul 2015 04:51:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZD7YT-0005tS-GA for guix-devel@gnu.org; Thu, 09 Jul 2015 04:51:44 -0400 Received: from mail-lb0-x22d.google.com ([2a00:1450:4010:c04::22d]:34389) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZD7YT-0005tK-6v for guix-devel@gnu.org; Thu, 09 Jul 2015 04:51:41 -0400 Received: by lbnk3 with SMTP id k3so70936222lbn.1 for ; Thu, 09 Jul 2015 01:51:40 -0700 (PDT) In-Reply-To: (Federico Beffa's message of "Wed, 8 Jul 2015 22:22:32 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Federico Beffa Cc: Guix-devel Federico Beffa (2015-07-08 23:22 +0300) wrote: > On Tue, Jul 7, 2015 at 6:58 PM, Alex Kost wrote: >> A side note: I think generally it would be preferable to use an upstream >> release in the package recipe rather than to use a melpa(-stable) URL, >> i.e.: >> >> http://foo-upstream.org/foo-0.1.tar.gz instead of >> http://stable.melpa.org/packages/foo-0.1.tar > > I believe that such information is not available from ELPA archives. > Therefore the ELPA importer has no way to do this. But, obviously, > manual modification is possible. (By the way, the tar files are > similar but not identical.) Surely, I didn't mean that it's a task for the elpa importer. I'm totally for the manual modification to use an upstream release, not the melpa(-stable) one. By "the tar files are similar" do you mean that MELPA usually leaves only elisp files in the tarballs? I think since it's a common practice to put elisp files in the root directory of the repo, we should add a phase to the emacs build system to remove non-elisp files (like .gitignore or README) from the final /gnu/store/=E2=80=A6-foo-0.1/share/emacs/site-lisp/guix.d/foo-0.1/ director= y. >> Also along with the concern that melpa stores a tarball only for the >> latest package version I think I've found another problem that will >> happen with a package from any repository: there are many single-file >> packages and these ones are not put in tarballs. I mean the package in >> this case is just a simple elisp file, so the 'unpack' will fail. >> >> Look at for example: >> >> guix import elpa --archive=3Dgnu rainbow-mode >> >> gives a package that fails on 'unpack' phase. > > Currently this can be handled, as in many packages using other build > systems, by custom phases. But handling of this type of packages would > definitely be useful. Unfortunately, in the near future, I will not > have time to spend on this. I've pushed the code as reviewed on the ML > today. If you are interested, feel free to improve/extend it. Thanks for the proposal :-) --=20 Alex