From: Ricardo Wurmus <rekado@elephly.net>
To: Pjotr Prins <pjotr.public12@thebird.nl>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: Add ruby-simplecov.
Date: Wed, 16 Sep 2015 11:34:18 +0200 [thread overview]
Message-ID: <87oah27lnp.fsf@elephly.net> (raw)
In-Reply-To: <55f8ead6.KirY0UdOBnhexzdH%pjotr.public12@thebird.nl>
Hi Pjotr,
> * gnu/packages/ruby.scm (ruby-simplecov): New variable.
[...]
> + (propagated-inputs
> + `(("ruby-docile" ,ruby-docile)
> + ("ruby-json" ,ruby-json)))
> + (arguments
> + '(#:tests? #f)) ; needs github-markup, among others
> + (synopsis "Code coverage for Ruby")
I find it very surprising to see only “docile” and “json” as inputs and
not “ruby-simplecov-html”. According to
https://rubygems.org/gems/simplecov “simplecov-html” is a runtime
dependency.
With my Ruby packages I’ve been closely following the dependencies as
they are declared on rubygems.org.
I’ve sent a patch to add “ruby-simplecov-html” to the ML a couple of
minutes ago, so maybe you could update your patch and add it as an
input.
> + (description "Code coverage analysis tool for Ruby. It uses Ruby's
> +built-in Coverage library to gather code coverage data, but makes
> +processing its results much easier by providing a clean API to filter,
> +group, merge, format, and display those results, giving you a complete
> +code coverage suite that can be set up with just a couple lines of
> +code.
> +")
The closing quote and the closing parenthesis should be on the same line
as the period. The rest looks good to me.
~~ Ricardo
next prev parent reply other threads:[~2015-09-16 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 4:06 [PATCH 2/2] gnu: Add ruby-simplecov Pjotr Prins
2015-09-16 9:34 ` Ricardo Wurmus [this message]
2015-09-17 5:20 ` Pjotr Prins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oah27lnp.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=pjotr.public12@thebird.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).