From: Alex Kost <alezost@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: guix: Set 'guix-dot-program' emacs variable.
Date: Sat, 17 Oct 2015 18:46:17 +0300 [thread overview]
Message-ID: <87oafxsdkm.fsf@gmail.com> (raw)
In-Reply-To: <87wpulk49m.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 17 Oct 2015 15:34:29 +0200")
Ludovic Courtès (2015-10-17 16:34 +0300) wrote:
> Alex Kost <alezost@gmail.com> skribis:
>
>> From dd793147718cb18766268c8aad50d24b88ffe6b6 Mon Sep 17 00:00:00 2001
>> From: Alex Kost <alezost@gmail.com>
>> Date: Fri, 16 Oct 2015 20:34:32 +0300
>> Subject: [PATCH 1/2] build: Set DOT_USER_PROGRAM for Emacs interface.
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> Suggested by Ludovic Courtès <ludo@gnu.org>.
>>
>> * configure.ac: Set DOT_USER_PROGRAM variable.
>> * emacs/guix-config.el.in (guix-config-dot-program): New constant.
>> * emacs/guix-external.el (guix-dot-program): Use it.
>
> [...]
>
>> +(defconst guix-config-dot-program "@DOT_USER_PROGRAM@"
>> + "Name of the 'dot' executable defined at the configure time.")
>
> “at configure time”
Thanks.
> The docstring should mention that it can be the empty string.
> Alternately, ‘configure’ could set DOT_USER_PROGRAM to “dot” when it’s
> not found, which I think is ever preferable. WDYT?
IMO an empty string is preferable (explained below), so I would like to
leave it like this (with an improved docstring as you pointed), if you
don't mind.
>> +(defcustom guix-dot-program
>> + (if (string= "" guix-config-dot-program)
>> + (executable-find "dot")
>> + guix-config-dot-program)
>
> Thus here we’d be checking whether ‘guix-config-dot-program’ is an
> absolute file name.
I think (executable-find "dot") is more reliable than just "dot" which
may not exist. So if there is no "dot" program, then ‘guix-dot-program’
variable will be set to nil. And once "dot" will be needed, a user will
get a useful (I hope) emacs error that "dot" is missing (it is handled
by ‘guix-dot-arguments’ function). While with just "dot" as you
suggest, there will be some unpleasant error in Guix REPL (it will
happen in ‘pipe-guix-output’ proc in “emacs/guix-main.scm”).
--
Alex
next prev parent reply other threads:[~2015-10-17 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 19:48 [PATCH] gnu: guix: Set 'guix-dot-program' emacs variable Alex Kost
2015-10-16 8:20 ` Ludovic Courtès
2015-10-16 18:21 ` Alex Kost
2015-10-17 13:34 ` Ludovic Courtès
2015-10-17 15:46 ` Alex Kost [this message]
2015-10-18 16:50 ` Ludovic Courtès
2015-10-19 14:49 ` Alex Kost
2015-10-19 15:41 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oafxsdkm.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).