From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/1] gnu: lua: Build with dynamic library support.
Date: Tue, 27 Oct 2015 13:47:04 +0100
Message-ID: <87oafkv5pz.fsf@gnu.org>
References: <cover.1445918045.git.leo@famulari.name>
	<cover.1445918045.git.leo@famulari.name>
	<45ab1898e5c08ef1f8c7070eae77c58e5dd40296.1445918045.git.leo@famulari.name>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48015)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zr3eg-00031j-1P
	for guix-devel@gnu.org; Tue, 27 Oct 2015 08:47:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zr3ec-00015s-Q6
	for guix-devel@gnu.org; Tue, 27 Oct 2015 08:47:09 -0400
In-Reply-To: <45ab1898e5c08ef1f8c7070eae77c58e5dd40296.1445918045.git.leo@famulari.name>
	(Leo Famulari's message of "Mon, 26 Oct 2015 23:56:09 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Leo Famulari <leo@famulari.name> skribis:

> Notably, this enables the use of dynamic libraries with Lua.

A better subject line for the commit would be:

  gnu: lua-5.2: Build shared libraries.

AFAICS, the problem is only with Lua 5.2:

--8<---------------cut here---------------start------------->8---
$ ls $(guix build lua-5.1)/lib
liblua.a  liblua.so  liblua.so.5.1  lua
$ ls $(guix build lua-5.2)/lib
liblua.a  lua  pkgconfig
--8<---------------cut here---------------end--------------->8---

Thus I would suggest leaving =E2=80=98lua-5.1=E2=80=99 unchanged.

> * gnu/packages/lua.scm (lua, lua-5.1)[arguments]: Set the make flags
>   properly for each version of lua.

[...]

> +++ b/gnu/packages/lua.scm
> @@ -24,6 +24,7 @@
>    #:use-module (guix packages)
>    #:use-module (guix download)
>    #:use-module (guix build-system gnu)
> +  #:use-module (guix utils)

Looks like this line is not needed, is it?

>         #:phases (alist-replace
>                   'build
> -                 (lambda _ (zero? (system* "make" "CFLAGS=3D-fPIC" "linu=
x")))
> +                 (lambda _ (zero? (system* "make" "MYCFLAGS=3D-fPIC" "li=
nux")))

I just tried and AFAICS this line has no effect: Lua 5.2 still lacks
liblua.so.  Am I missing something?

> +          `(modify-phases ,lua-phases
> +             (replace
> +               'build
> +               (lambda _
> +                 (and
> +                  (zero? (system* "make" (string-append
> +                                    "MYCFLAGS=3D"
> +                                    (string-join '("-fPIC "
> +                                                   "-DLUA_USE_LINUX "
> +                                                   "MYLIBS=3D-Wl,-E "
> +                                                   "-ldl -lreadline "
> +                                                   "-lhistory -lncurses"=
)))
> +                                    "linux")))))))))))

This is in =E2=80=98lua-5.1=E2=80=99, so it=E2=80=99s unnecessary AFAICS.

> @@ -89,8 +106,8 @@ for configuration, scripting, and rapid prototyping.")
>                                    version ".tar.gz"))
>                (sha256
>                 (base32 "0ydxpqkmsn2c341j4r2v6r5r0ig3kbwv3i9jran3iv81s6r6=
rgjm"))
> -	      (patches (list (search-patch "luajit-symlinks.patch")
> -			     (search-patch "luajit-no_ldconfig.patch")))))
> +              (patches (list (search-patch "luajit-symlinks.patch")
> +                             (search-patch "luajit-no_ldconfig.patch")))=
))

Unnecessary too.

Thanks for looking into it!

Ludo=E2=80=99.