From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/3] emacs: Add key bindings for
	'guix-build-log-minor-mode'.
Date: Fri, 30 Oct 2015 17:51:49 +0100
Message-ID: <87oafge1ui.fsf@gnu.org>
References: <877fm5za7d.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46586)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZsCuD-0006SB-2q
	for guix-devel@gnu.org; Fri, 30 Oct 2015 12:51:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZsCu8-0000dh-3U
	for guix-devel@gnu.org; Fri, 30 Oct 2015 12:51:56 -0400
In-Reply-To: <877fm5za7d.fsf@gmail.com> (Alex Kost's message of "Thu, 29 Oct
	2015 23:33:26 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

Alex Kost <alezost@gmail.com> skribis:

> I use (add-hook 'shell-mode-hook 'guix-build-log-minor-mode) and I found
> that along with phases highlighting, it is useful to have some key
> bindings available in this minor mode, so this patch adds "C-c
> M-n/M-p/TAB/S-TAB" keys to it.

Excellent!

> From fe50e7233fa5144f31f7db583d0289f056dd9dd0 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Thu, 29 Oct 2015 21:27:56 +0300
> Subject: [PATCH 2/3] emacs: Add key bindings for 'guix-build-log-minor-mo=
de'.
>
> * emacs/guix-build-log.el (guix-build-log-mode-map): Move keys to ...
>   (guix-build-log-common-map): ...here.  New variable.
>   (guix-build-log-minor-mode-map): New variable.
>   (guix-build-log-minor-mode): Use it.
> * doc/emacs.texi (Emacs Build Log): Document it.

OK to push.

> +  (add-hook 'shell-mode-hook 'guix-build-log-minor-mode)

I wonder if we should do that automatically by default.  That way
everyone would get the cool features, even those who didn=E2=80=99t bother =
to
read all the manual.

WDYT?

Thanks,
Ludo=E2=80=99.