Re: [PATCH] Add einstein.

[Ricardo Wurmus <rekado@elephly.net>]

Andreas Enge <andreas@enge.fr> writes:

> the attached patch adds a game the source code of which has almost
> disappeared... So lots of annoying little things to change. I do it (mostly)
> in a build phase right now; should I rather use a patch?

I think it would be clearer to use a patch in this case.

> The one thing that bothers me is the lack of license: Debian claims it
> is gpl2+ and included the package in previous editions; the source code itself
> has no hint of a license, the website from archive.org speaks of "free cross-
> platform open source" without further detail.
>
> Actually Debian at
>    http://metadata.ftp-master.debian.org/changelogs/main/e/einstein/unstable_copyright
> also gives an author; so at some point in time in some galaxy, more information must
> have been available...
>
> There is actually more info in a Debian bug report!
>    https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=289339
> It points to the following page:
>    http://www.babichev.info/en/projects/index.html
> Looking at:
>    http://web.archive.org/web/20150222180355/http://www.babichev.info/en/projects/index.html
> "(...) Einstein (...)
> All software published under the terms of GNU General Public License."
> Following the link leads to here:
>    http://web.archive.org/web/20150221145051/http://www.gnu.org/licenses/gpl.html
>
> So is this okay to include under gpl3+?
> (In which case I would update the patch and also add a pointer to
>    http://web.archive.org/web/20150222180355/http://www.babichev.info/en/projects/index.html).

I don’t know what to do about this.  It’s unfortunate that the code
itself has no license headers.  The download page of the game says

    “You can download game for free under GPL license terms.”
    http://web.archive.org/web/20121029043853/http://games.flowix.com/en/index.html

If the code provided there is identical to the code you download from
Debian then I think it would be justified to declare the license as
GPLv3+.

> From 0261d4b0a587f402f76d83ccddf97b2cf70a03e0 Mon Sep 17 00:00:00 2001
> From: Andreas Enge <andreas@enge.fr>
> Date: Sat, 27 Feb 2016 17:21:04 +0100
> Subject: [PATCH] gnu: Add einstein.

[...]

> +
> +(define-public einstein
> +  (package
> +    (name "einstein")
> +    (version "2.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://http.debian.net/debian/pool/main/e/"
> +                                  "einstein/einstein_2.0.dfsg.2.orig.tar.gz"))
> +              (sha256
> +               (base32
> +                "1hxrlv6n8py48j487i6wbb4n4vd55w0na69r7ccmmr9vmrsw5mlk"))
> +              (patches (list (search-patch "einstein-install.patch")))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("freetype" ,freetype)
> +       ("sdl" ,sdl)
> +       ("sdl-mixer" ,sdl-mixer)
> +       ("sdl-ttf" ,sdl-ttf)
> +       ("zlib" ,zlib)))
> +    (native-inputs
> +     `(("font-dejavu" ,font-dejavu)))
> +    (arguments
> +     `(#:tests? #f ; no check target
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'configure
> +         (lambda* (#:key outputs inputs #:allow-other-keys)

The indentation is wrong here.

> +           (let ((out (assoc-ref outputs "out"))
> +                 (dejavu (string-append (assoc-ref inputs "font-dejavu")
> +                                        "/share/fonts/truetype/DejaVuSans.ttf")))
> +             (substitute* "Makefile"
> +               (("PREFIX=/usr/local") (string-append "PREFIX=" out)))

Could this be done via make-flags instead?

> +             ;; Replace proprietary fonts by free one.
> +             ;; The font is copied during the compile phase into a resources
> +             ;; file, so we need to make the ttf file available.
p
Is the proprietary font part of the source archive?

> +             ;; Fix compilation with current gcc.
> +             (substitute* (find-files "." "\\.(cpp|h)$")
> +               (("SDL_mixer.h") "SDL/SDL_mixer.h")
> +               (("SDL_ttf.h") "SDL/SDL_ttf.h"))
> +             (substitute*
> +               '("convert.h" "mkres/convert.h")
> +               (("iostream") "iostream>\n#include <typeinfo"))
> +             (substitute*
> +               '("mkres/main.cpp" "mkres/compressor.cpp" "mkres/unicode.cpp"
> +                 "unicode.cpp")
> +               (("exceptions.h") "exceptions.h\"\n#include \"string.h"))

I think this should be done with a patch instead.

~~ Ricardo