From: ludo@gnu.org (Ludovic Courtès)
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: Alex Sassmannshausen <alex.sassmannshausen@gmail.com>,
guix-devel@gnu.org
Subject: Re: [PATCH 2/3] gnu: Add perl-log-log4perl.
Date: Sun, 17 Jul 2016 15:27:39 +0200 [thread overview]
Message-ID: <87oa5w4cok.fsf@gnu.org> (raw)
In-Reply-To: <578AF627.5090707@uq.edu.au> (Ben Woodcroft's message of "Sun, 17 Jul 2016 13:06:15 +1000")
Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:
> On 17/07/16 04:20, Alex Sassmannshausen wrote:
>> * gnu/packages/perl.scm (perl-log-log4perl): New variable.
>> ---
>> gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>>
>> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
>> index 486dbc2..fc63df3 100644
>> --- a/gnu/packages/perl.scm
>> +++ b/gnu/packages/perl.scm
>> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>> mechanism.")
>> (license (package-license perl))))
>> +(define-public perl-log-log4perl
>> + (package
>> + (name "perl-log-log4perl")
>> + (version "1.47")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "mirror://cpan/authors/id/M/MS/MSCHILLI/Log-Log4perl-"
>> + version
>> + ".tar.gz"))
>> + (sha256
>> + (base32
>> + "0vxraq9navx5mgf8y8g6l5rbl3dv2ml8bishka5m69hj07nxs0ch"))))
>> + (build-system perl-build-system)
>> + (home-page
>> + "http://search.cpan.org/dist/Log-Log4perl")
>> + (synopsis "Log4j implementation for Perl")
>> + (description "Log::Log4perl lets you remote-control and fine-tune the
>> +logging behaviour of your system from the outside. It implements the widely
>> +popular (Java-based) Log4j logging package in pure Perl.
>> +
>> +For a detailed tutorial on Log::Log4perl usage, please read
>> +
>> +http://www.perl.com/pub/a/2002/09/11/log4perl.html")
>
> Is it appropriate to wrap this URL in some tex? I'm not sure what
> would be appropriate in this case. Otherwise LGTM.
I think “For a detailed tutorial …” doesn’t belong in the description.
The description should just give an idea of what this is about, IMO.
Alex, could you also wrap module names in @code{}?
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2016-07-17 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 18:20 [PATCH 0/3] Add perl-log modules Alex Sassmannshausen
2016-07-16 18:20 ` [PATCH 1/3] gnu: Add perl-log-any Alex Sassmannshausen
2016-07-17 3:04 ` Ben Woodcroft
2016-07-16 18:20 ` [PATCH 2/3] gnu: Add perl-log-log4perl Alex Sassmannshausen
2016-07-17 3:06 ` Ben Woodcroft
2016-07-17 13:27 ` Ludovic Courtès [this message]
2016-07-16 18:20 ` [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl Alex Sassmannshausen
2016-07-17 3:10 ` Ben Woodcroft
2016-07-17 8:44 ` Ricardo Wurmus
-- strict thread matches above, loose matches on Subject: below --
2016-07-28 10:56 [PATCH 0/3] Perl log patches fixed Alex Sassmannshausen
2016-07-28 10:56 ` [PATCH 2/3] gnu: Add perl-log-log4perl Alex Sassmannshausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa5w4cok.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=alex.sassmannshausen@gmail.com \
--cc=b.woodcroft@uq.edu.au \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).