From: ludo@gnu.org (Ludovic Courtès)
To: "Jan Synáček" <jan.synacek@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: guix system: error: service 'ssh-daemon' requires 'networking', which is undefined
Date: Thu, 21 Jul 2016 15:00:41 +0200 [thread overview]
Message-ID: <87oa5rm9hi.fsf@gnu.org> (raw)
In-Reply-To: <CACA+5f3DKAK=v2FmVQuAVgjWcH8TK_xLc4fvj-Qh3SwnNTK5pg@mail.gmail.com> ("Jan \=\?utf-8\?B\?U3luw6HEjWVrIidz\?\= message of "Thu, 21 Jul 2016 08:30:16 +0200")
Jan Synáček <jan.synacek@gmail.com> skribis:
> On Tue, Jul 19, 2016 at 2:43 PM, Ludovic Courtès <ludo@gnu.org> wrote:
>> I improved the message along these lines in commit
>> 2c2ec261a8d3c37e5147038f47ad24c57cde4134, let me know what you think.
>>
>> To be more concrete about other improvements, here’s what should be
>> feasible (but needs to be discussed to see whether it’s actually
>> helpful):
>>
>> 1. Display the location of the Shepherd service definition:
>>
>> gnu/services/ssh.scm:160:4: 'ssh-daemon' requires 'networking'…
>>
>> Trivial to implement, but the downside is that the user doesn’t
>> really care about this file.
>>
>> 2. Same, but also show some sort of a stack trace (but not an actual
>> Scheme stack trace) showing where this Shepherd service comes from:
>>
>> gnu/services/ssh.scm:160:4: 'ssh-daemon' requires 'networking'…
>> gnu/services/ssh.scm:117:30: … in extension of service 'shepherd'
>> gnu/services/ssh.scm:228:2: … while folding service 'lsh’ instantiated here
>>
>> The problem is that, currently, we’d get the location of the
>> (service …) form, which is in the ‘lsh-service’ procedure, in
>> gnu/services/ssh.scm.
>>
>> It may be hard to come up with intelligible messages, and there’s a
>> risk that showing too many lines of messages would be
>> counterproductive.
>>
>> Thoughts?
Just to be clear, the message we now have is:
service 'ssh-daemon' requires 'networking', which is not provided by any service
> From a regular user's point of view, this still misses the point,
> which I originally attempted to make. I suggest an error message like
> this:
>
> 'ssh-daemon' requires 'networking', try adding
> 'static-networking-service' or 'dhcp-client-service' to system
> services
>
> Or something like that. The point is, make it clear that "requires
> networking" means adding at least one service to the operating
> system's services and make at least one suggestion. Definitely a step
> forward to user friendliness.
So I think you’re saying that, in addition to the error message, you’d
like suggestions.
I like the idea. However, in this specific case, I’m not sure how to
achieve it: ‘guix system’ doesn’t know about all the Shepherd services
that can possibly exist, so it cannot tell you that the ‘networking’ is
provided if you add ‘dhcp-client-service’ or whatnot to your config
file.
I understand these are not details one cares about as a user, at least
at first glance. But this limits what we can do.
Thanks,
Ludo’.
next prev parent reply other threads:[~2016-07-21 13:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 12:39 guix system: error: service 'ssh-daemon' requires 'networking', which is undefined David Craven
2016-07-15 12:58 ` Jan Synáček
2016-07-15 14:27 ` Vincent Legoll
2016-07-17 6:50 ` Jan Synáček
2016-07-15 16:50 ` Ludovic Courtès
2016-07-15 18:04 ` Tobias Geerinckx-Rice
2016-07-19 12:43 ` Ludovic Courtès
2016-07-21 6:30 ` Jan Synáček
2016-07-21 8:48 ` Vincent Legoll
2016-07-21 12:54 ` Ludovic Courtès
2016-07-21 13:00 ` Ludovic Courtès [this message]
2016-07-21 13:35 ` Vincent Legoll
2016-07-21 13:57 ` Jan Synáček
2016-07-21 14:39 ` Thompson, David
2016-07-21 15:35 ` Andy Wingo
2016-07-21 16:10 ` Ludovic Courtès
2016-07-21 13:36 ` Jan Synáček
-- strict thread matches above, loose matches on Subject: below --
2016-07-15 12:24 Jan Synáček
2016-07-15 15:05 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa5rm9hi.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=jan.synacek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).