From: Mathieu Lirzin <mthl@gnu.org>
To: Alex Griffin <a@ajgrf.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: password-store: Wrap PATH.
Date: Fri, 29 Jul 2016 18:57:37 +0200 [thread overview]
Message-ID: <87oa5gcrge.fsf@gnu.org> (raw)
In-Reply-To: <1469802446.294760.680423961.0E2B23C1@webmail.messagingengine.com> (Alex Griffin's message of "Fri, 29 Jul 2016 09:27:26 -0500")
Alex Griffin <a@ajgrf.com> writes:
> On Fri, Jul 29, 2016, at 09:02 AM, Thompson, David wrote:
>> Sorry I'm late, but I don't think this is the right fix.
Sorry for not letting you the time to respond.
>> Wrapping programs should only be considered after other options are
>> exhausted. The correct fix is to patch the source directly to refer
>> to executables by their absolute path. Why wasn't it done this way?
>
> Mostly because it would be a lot of on-going work every time the package
> is updated. As a shell script, it invokes an external tool nearly every
> other line. If you look at the discussion that happened in February when
> the package was first added [1], Jessica (the original packager) was
> really discouraged by the prospect of patching every invocation of an
> external tool. She also tried to submit changes upstream so that kind of
> work wouldn't be necessary, but upstream wasn't very receptive to the
> idea. In the end, the package was just committed to Guix in a broken
> state.
>
> Another approach I considered was adding a bunch of shell aliases to the
> top of the script pointing to the Guix store. That makes the problem a
> lot more tractable than replacing every external invocation, but it's
> still kinda complicated and it still requires finding every single
> program that gets called and keeping it up to date with new releases. So
> even if all upstream does is use another program from coreutils, the fix
> would be out-of-date again.
>
> [1]: https://lists.gnu.org/archive/html/guix-devel/2016-02/msg01310.html
This makes sense to me.
--
Mathieu Lirzin
prev parent reply other threads:[~2016-07-29 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 0:20 [PATCH] gnu: password-store: Wrap PATH Alex Griffin
2016-07-29 0:38 ` Alex Griffin
2016-07-29 9:07 ` Mathieu Lirzin
2016-07-29 14:02 ` Thompson, David
2016-07-29 14:27 ` Alex Griffin
2016-07-29 16:57 ` Mathieu Lirzin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa5gcrge.fsf@gnu.org \
--to=mthl@gnu.org \
--cc=a@ajgrf.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).