unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add schismtracker.
Date: Sat, 10 Sep 2016 14:55:12 +0200	[thread overview]
Message-ID: <87oa3voqxb.fsf@gnu.org> (raw)
In-Reply-To: <87poocqkc7.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Sat, 10 Sep 2016 08:34:32 +0100")

Marius Bakke <mbakke@fastmail.com> skribis:

> Kei Kebreau <kei@openmailbox.org> writes:

[...]

>> +    (home-page "http://schismtracker.org")
>> +    (synopsis "Impulse Tracker clone")
>
> I think this should be more generic. The tagline from github works
> pretty well: "Oldschool sample-based music composition tool".

+1

> The rest LGTM. But! The package records build time in version.c. I
> managed to make it reproducible by adding a phase like this:
>
>           (add-before 'build 'make-reproducible
>             (lambda _
>               ;; Remove use of __DATE__ and __TIME__ for reproducibility.
>               (substitute* "schism/version.c"
>                 (("Schism Tracker built %s %s.*$")
>                  (string-append "Schism Tracker version " ,version "\");")))
>               #t))

I would suggest making it a ‘snippet’ instead, as we usually do in such
cases.

Thanks Kei & Marius!

Ludo’.

  reply	other threads:[~2016-09-10 12:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09 22:19 [PATCH] gnu: Add schismtracker Kei Kebreau
2016-09-10  7:34 ` Marius Bakke
2016-09-10 12:55   ` Ludovic Courtès [this message]
     [not found]     ` <87mvjfg74n.fsf@openmailbox.org>
2016-09-11 13:38       ` Kei Kebreau
2016-09-13 11:50         ` Ludovic Courtès
2016-09-13 14:33           ` Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oa3voqxb.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).