From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 5/5] guix: python-build-system: Fix an outdated comment.
Date: Thu, 13 Oct 2016 22:06:58 +0200
Message-ID: <87oa2o9fod.fsf@gnu.org>
References: <1476105003-29538-1-git-send-email-h.goebel@crazy-compilers.com>
	<1476105003-29538-6-git-send-email-h.goebel@crazy-compilers.com>
	<20161012160343.GE31109@jasmine>
	<57FF388F.9000002@crazy-compilers.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39899)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bumHR-0004JR-MF
	for guix-devel@gnu.org; Thu, 13 Oct 2016 16:07:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bumHN-0001kv-Ee
	for guix-devel@gnu.org; Thu, 13 Oct 2016 16:07:04 -0400
In-Reply-To: <57FF388F.9000002@crazy-compilers.com> (Hartmut Goebel's message
	of "Thu, 13 Oct 2016 09:32:31 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 12.10.2016 um 18:03 schrieb Leo Famulari:
>>> >  (define %standard-phases
>>> > -  ;; 'configure' and 'build' phases are not needed.  Everything is d=
one during
>>> > -  ;; 'install'.
>>> > +  ;; 'configure' phase is not needed.
>> I have no real comment because I don't know the python-build-system well
>> enough. Is the sentence about 'install' no longer accurate?
>
> The python-build-system uses the build and the install phase, but not
> the configure phase. So the old comment was plain wrong. I assume once
> only the install phase was used[*] and the comment has had been correct :=
-)
>
> Which is possible and much like running "make install" without prior run
> to "make".

Indeed, I think this has been the case since commit
b191f88ee34576a6908b9b5e94cb7664e88c7e79.

Note however that Mark reverted this patch from master because it would
have caused a rebuild of all things Python.  However feel free to apply
it to wip-python-build-system.

Thanks,
Ludo=E2=80=99.