From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add supertuxkart.
Date: Tue, 18 Oct 2016 14:44:29 +0200 [thread overview]
Message-ID: <87oa2hltci.fsf@gnu.org> (raw)
In-Reply-To: <20161017213754.8462-1-rekado@elephly.net> (Ricardo Wurmus's message of "Mon, 17 Oct 2016 23:37:54 +0200")
Ricardo Wurmus <rekado@elephly.net> skribis:
> * gnu/packages/games.scm (supertuxkart): New variable.
Woohoo!
> + (snippet
> + ;; Delete bundled library sources
> + '(begin
> + ;; FIXME: try to unbundle enet, and angelscript
> + (for-each delete-file-recursively
> + '("lib/zlib"
> + "lib/libpng"
> + "lib/jpeglib"
> + "lib/glew"
> + "lib/wiiuse"))
> + #t))))
[...]
> + (substitute* "CMakeLists.txt"
> + ;; Supertuxkart uses modified versions of the Irrlicht engine
> + ;; and the bullet library. The developers gave an explanation here:
> + ;; http://forum.freegamedev.net/viewtopic.php?f=17&t=3906
> + (("add_subdirectory\\(.*/(glew|zlib)\"\\)") "")
I think this clause should go to the snippet above.
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2016-10-18 12:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 21:37 [PATCH] gnu: Add supertuxkart Ricardo Wurmus
2016-10-18 12:44 ` Ludovic Courtès [this message]
2016-10-23 13:11 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa2hltci.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).