From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marius Bakke <mbakke@fastmail.com>
Subject: Re: [PATCH] gnu: Add whois.
Date: Tue, 18 Oct 2016 14:03:18 +0100
Message-ID: <87oa2h7qsp.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me>
References: <20161018080454.4775-1-ng0@we.make.ritual.n0.is>
	<20161018080454.4775-2-ng0@we.make.ritual.n0.is>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48443)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1bwU3B-0004ap-C0
	for guix-devel@gnu.org; Tue, 18 Oct 2016 09:03:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1bwU36-0000a5-Bn
	for guix-devel@gnu.org; Tue, 18 Oct 2016 09:03:25 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:46912)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mbakke@fastmail.com>) id 1bwU36-0000Zp-7r
	for guix-devel@gnu.org; Tue, 18 Oct 2016 09:03:20 -0400
In-Reply-To: <20161018080454.4775-2-ng0@we.make.ritual.n0.is>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ng0 <ng0@we.make.ritual.n0.is>, guix-devel@gnu.org

ng0 <ng0@we.make.ritual.n0.is> writes:

> * gnu/packages/networking.scm (whois): New variable.

Thanks! This works for me. I have a couple of remarks that can be added
before committing if you agree, no need to send an updated patch.

* The source headers seems to indicate that this is GPL2+.
* The only reference to this program on the home page is a link to
  GitHub, do you think we should use that as home-page?
* Gettext only seems used for building locales and is not referenced at
  runtime, perhaps it should be a native-input?
* The Debian package is built with HAVE_ICONV=1, should we set that too?

Additionally it installs locales, but looks for /usr/share/locale at
runtime. Fixing this would probably require upstream help, I don't want
to hardcode either "/run/current-system/locale" or ~/.guix-profile. The
current version probably works on foreign distros, if nothing else.

Are these changes sensible?