From: Marius Bakke <mbakke@fastmail.com>
To: ng0 <ng0@we.make.ritual.n0.is>, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add whois.
Date: Tue, 18 Oct 2016 14:03:18 +0100 [thread overview]
Message-ID: <87oa2h7qsp.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20161018080454.4775-2-ng0@we.make.ritual.n0.is>
ng0 <ng0@we.make.ritual.n0.is> writes:
> * gnu/packages/networking.scm (whois): New variable.
Thanks! This works for me. I have a couple of remarks that can be added
before committing if you agree, no need to send an updated patch.
* The source headers seems to indicate that this is GPL2+.
* The only reference to this program on the home page is a link to
GitHub, do you think we should use that as home-page?
* Gettext only seems used for building locales and is not referenced at
runtime, perhaps it should be a native-input?
* The Debian package is built with HAVE_ICONV=1, should we set that too?
Additionally it installs locales, but looks for /usr/share/locale at
runtime. Fixing this would probably require upstream help, I don't want
to hardcode either "/run/current-system/locale" or ~/.guix-profile. The
current version probably works on foreign distros, if nothing else.
Are these changes sensible?
next prev parent reply other threads:[~2016-10-18 13:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 8:04 [PATCH] gnu: Add whois ng0
2016-10-18 8:04 ` ng0
2016-10-18 13:03 ` Marius Bakke [this message]
2016-10-18 13:50 ` ng0
2016-10-18 15:10 ` Marius Bakke
2016-10-22 11:04 ` ng0
2016-10-22 11:24 ` ng0
2016-10-22 16:09 ` Marius Bakke
2016-10-22 18:57 ` ng0
2016-10-22 19:21 ` Marius Bakke
2016-10-22 19:28 ` ng0
2016-10-24 16:52 ` Marius Bakke
2017-01-04 17:41 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa2h7qsp.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=guix-devel@gnu.org \
--cc=ng0@we.make.ritual.n0.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).