From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 6/6] gnu: Add grub-efi. Date: Mon, 07 Nov 2016 09:23:36 +0000 Message-ID: <87oa1r8wyv.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20161105125511.29383-1-mbakke@fastmail.com> <20161105125511.29383-7-mbakke@fastmail.com> <20161105185803.GA11667@jasmine> <87h97l67kz.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <878tsww9ov.fsf@gnu.org> <87vaw087kr.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <871syny88o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3g9W-0007rw-Fi for guix-devel@gnu.org; Mon, 07 Nov 2016 04:23:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3g9T-0005L3-8o for guix-devel@gnu.org; Mon, 07 Nov 2016 04:23:42 -0500 In-Reply-To: <871syny88o.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: >>>> From 940c03c7dcddec019e27f6eb1470aeab4db57799 Mon Sep 17 00:00:00 2001 >>>> From: Marius Bakke >>>> Date: Thu, 20 Oct 2016 17:26:52 +0100 >>>> Subject: [PATCH] gnu: Add grub-efi. >>>> >>>> * gnu/packages/grub.scm (grub-efi): New variable. >>> >>> [...] >>> >>>> + (name "grub-efi") >>>> + (synopsis (string-append (package-synopsis grub) " (UEFI version)= ")) >>> >>> Please use a literal string for =E2=80=98synopsis=E2=80=99; use of =E2= =80=98string-append=E2=80=99 like >>> this prevents i18n. >>> >>>> + `(#:tests? #f ; FIXME: 40 failures, 24 skipped, 17 passed. >>> >>> It would be good to investigate, especially if the tests pass in the >>> =E2=80=98grub=E2=80=99 package. >>> >>> Also, what=E2=80=99s the rationale for making =E2=80=98grub-efi=E2=80= =99 separate instead of >>> incorporating the changes in =E2=80=98grub=E2=80=99 proper? Are there = issues around the >>> portability of =E2=80=98efibootmgr=E2=80=99, or an increased closure si= ze? >> >> This is a good point. The only difference with "--with-platform=3Defi" is >> that another directory is created in place of the i386-pc directory. It >> is perfectly possible to build multiple platforms and copying the >> platform-specific stuff to $out/lib -- grub will pick the correct >> platform at runtime. This is what the Gentoo ebuild does. > > Are you saying that a GRUB compiled with UEFI support will no longer > work out-of-the-box on non-UEFI machines, unless platform-specific stuff > is moved like you suggest? Ha, no, it was just a long-winded and intoxicated way of saying what you proposed should work fine. :) The platform-specific stuff ends up in $out/lib/ by default, so there won't be any conflicts there, and grub-install will pick the correct one automatically. That approach is better, I think. Will have a go at it. The tricky part is invoking the 'configure, 'build and 'install steps with appropriate arguments for each platform in the grub expression, but that does not sound too difficult. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJYIEgYAAoJEKKgbfKjOlT699sH/2A0Tpcban2RNQz1NkFUiMsc /x8sy20VI2CMWzW8RZs9zC+zemPzCc7hVXLhv0Qd18+hrilqh8NbOHHUbLE5peW9 IHmOLXqp1+6gJvEnUNHl9lBJMqOJPsMbYFHmJuhSZXjVo9/EjSgFt/c1/NjZY9Ag Qbs7QYn++Fcmu1J/LbfyoAauhK9xsjlRyXx3QXHEq7gdU+77PPJNrifUby2KHP9i Kuweo/Ly8pdMkONlh0NXiIwbdMr0xklDUNsIz6yaT/qxHfOa1whd5XRcub7B1Omf e1s5mCdeBSVBvYZ8YU5aqDtG406+gQVVJPC4nxee2JC0JxT5ix8ZKImbM0bQWic= =0UaP -----END PGP SIGNATURE----- --=-=-=--