From: "Huang\, Ying" <huang_ying_caritas@163.com>
To: iyzsong@member.fsf.org
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: font-gnu-unifont: Call mkfontdir for pcf output
Date: Sun, 05 Feb 2017 20:19:07 +0800 [thread overview]
Message-ID: <87o9ygg79g.fsf@163.com> (raw)
In-Reply-To: <87bmuhgc5a.fsf@163.com> (Ying Huang's message of "Sun, 05 Feb 2017 18:33:37 +0800")
"Huang, Ying" <huang_ying_caritas@163.com> writes:
> Hi, Wenwu,
>
> Thanks for comments!
>
> iyzsong@member.fsf.org (宋文武) writes:
>
>> huang_ying_caritas@163.com writes:
>>
>>> * gnu/packages/fonts.scm (font-gnu-unifont): call mkfontdir for pcf output.
>>>
>>> Signed-off-by: "Huang, Ying" <huang.ying.caritas@gmail.com>
>>> ---
>>> gnu/packages/fonts.scm | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
>>> index 1f6d1d0c3..088a6bec9 100644
>>> --- a/gnu/packages/fonts.scm
>>> +++ b/gnu/packages/fonts.scm
>>> @@ -671,13 +671,15 @@ languages, plus Greek and Cyrillic.")
>>> (string-append "PCFDEST=" pcf)
>>> (string-append "CONSOLEDEST=" psf)
>>> "install")
>>> + (system* "mkfontdir" pcf)
>>
>> This will create 'share/fonts/misc/fonts.dir' in the 'pcf' output of
>> font-gnu-unifont package. When multiple packages have this file,
>> collisions occour and then I guess it won't work as expected.
>
> I think so too.
>
>> The right
>> place to create this file is the 'fonts-dir-file' hook in profiles.scm,
>> currently it does 'mkfontscale' and 'mkfontdir' only for truetype fonts
>> under 'share/fonts/truetype', which can be extended for each directory
>> under 'share/fonts'. What do you think?
>
> I think that is better. I have thought about that before. But I didn't
> know whether that is necessary in general at that time.
One problem of this solution is that some font packages (for example,
fonts-misc-misc) already have fonts.dir, to avoid conflict, it is better
to remove fonts.dir in all font packages and generate fonts.dir in
fonts-dir-file, I think that is good. But I don't know whether others
think that is a good idea.
Best Regards,
Huang, Ying
next prev parent reply other threads:[~2017-02-05 12:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-05 5:03 [PATCH] gnu: font-gnu-unifont: Call mkfontdir for pcf output huang_ying_caritas
2017-02-05 6:49 ` 宋文武
2017-02-05 10:33 ` Huang, Ying
2017-02-05 12:19 ` Huang, Ying [this message]
2017-02-14 17:56 ` Danny Milosavljevic
2017-02-15 10:55 ` Alex Kost
2017-02-15 11:51 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9ygg79g.fsf@163.com \
--to=huang_ying_caritas@163.com \
--cc=guix-devel@gnu.org \
--cc=iyzsong@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).