From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: ntfs-3g: Fix CVE-2017-0358. Date: Fri, 10 Feb 2017 00:07:35 +0100 Message-ID: <87o9ybrmiw.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <87bmuboxqf.fsf@openmailbox.org> <878tpft2dt.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20170209224346.GA20362@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbxoT-0000De-El for guix-devel@gnu.org; Thu, 09 Feb 2017 18:07:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbxoQ-0002Dl-2s for guix-devel@gnu.org; Thu, 09 Feb 2017 18:07:41 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:42975) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cbxoP-0002DT-Lu for guix-devel@gnu.org; Thu, 09 Feb 2017 18:07:37 -0500 In-Reply-To: <20170209224346.GA20362@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Thu, Feb 09, 2017 at 11:39:42PM +0100, Marius Bakke wrote: >> Kei Kebreau writes: >>=20 >> > Reviewers, how does this patch look to you? >>=20 >> AFAIU from CVE-2017-0358, ntfs-3g is only vulnerable when installed >> setuid root, which is not the case on guix. >>=20 >> FWIW Debian do not carry this patch, but have fixed the CVE according to >> the changelog. So I doubt this patch is necessary. > > There have been a couple security-related bugs publicized recently that > are only dangerous when the software is installed setuid root. > > Although we don't do that by default, system administrators can do it on > GuixSD. I also think that Guix is valuable as a distribution mechanism > of free source code, and we should fix bugs for that use case. > > So, I was thinking that we should fix these bugs unless they require > grafting, and then we should fix them in core-updates. > > WDYT? That does make a lot of sense. Reading up on execl(3), it looks like this patch does the right thing and can't hurt even when not setuid. Mind=3Dchanged! :P=20 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlic9jcACgkQoqBt8qM6 VPpgjAf/ZPoFbJ4EuSj/9g3i78ez9R14WkEh0nrnZLtgWkDTL+M2+LJwtpVP8R0v XcntJRYDtXp00qSHiIT45WCgdo/sw0YSuZLs7bnHvkY/R9ZeHIz4UyzKDiz87o8O IadCfhXFuaoShN54QGIpTnEY46kHNrqtJb9ZvrWFSUQaiMwFmJ8pe55gVFR6miLS dVjO+xGJ9/J2v37B0+2/j4sdA4wK46qXukeO9+rACs0O27Dlv5Z4W5xSn+KeVfpY qaqHZuQELIyne3jnpE2EE4WWuuWZHruvEb0o7obui3cUeMVM5vJiAHGT/bEO/gHS ZDapZlGrqum+KBX22YCXauqYtqV+eA== =86RU -----END PGP SIGNATURE----- --=-=-=--