From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Cournoyer Subject: Re: [PATCH 3/3] gnu: Add filezilla. Date: Sun, 12 Feb 2017 18:36:45 -0800 Message-ID: <87o9y64y0y.fsf@gmail.com> References: <20170209163618.1759-1-rennes@openmailbox.org> <20170209163618.1759-4-rennes@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cd6VU-0002fY-9u for guix-devel@gnu.org; Sun, 12 Feb 2017 21:36:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cd6VS-00024g-NM for guix-devel@gnu.org; Sun, 12 Feb 2017 21:36:48 -0500 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:34786) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cd6VS-00024a-I5 for guix-devel@gnu.org; Sun, 12 Feb 2017 21:36:46 -0500 Received: by mail-pg0-x241.google.com with SMTP id v184so8429025pgv.1 for ; Sun, 12 Feb 2017 18:36:46 -0800 (PST) List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: rennes Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, rennes writes: > * gnu/packages/ftp.scm (filezilla): New variable. > --- > gnu/packages/ftp.scm | 48 ++++++++++++++++++++++++++++++++++++++++++++++= +- > 1 file changed, 47 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/ftp.scm b/gnu/packages/ftp.scm > index 0fef1b160..129f04ef6 100644 > --- a/gnu/packages/ftp.scm > +++ b/gnu/packages/ftp.scm > @@ -27,12 +27,20 @@ > #:use-module (guix packages) > #:use-module (gnu packages) > #:use-module (gnu packages autotools) > - #:use-module (gnu packages check)=20=20 > + #:use-module (gnu packages glib) > + #:use-module (gnu packages gtk) Minor thing, and I'm not sure if we have a convention for this, but it'd be neat to keep the use-module statements ordered alphabetically. > + #:use-module (gnu packages check) > + #:use-module (gnu packages databases) > + #:use-module (gnu packages freedesktop)=20=20 > #:use-module (gnu packages gettext) > + #:use-module (gnu packages libidn)=20=20 > #:use-module (gnu packages ncurses) > + #:use-module (gnu packages nettle)=20=20 > #:use-module (gnu packages readline) > #:use-module (gnu packages pkg-config) > #:use-module (gnu packages tls) > + #:use-module (gnu packages wxwidgets) > + #:use-module (gnu packages xml)=20=20 > #:use-module (gnu packages compression)) >=20=20 > (define-public lftp > @@ -183,3 +191,41 @@ as required.") > "This package offering some basic functionality to build high-perfo= rming, > platform-independent programs.") > (license gpl3+))) > + > +(define-public filezilla > + (package > + (name "filezilla") > + (version "3.24.0") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://sourceforge.net/projects/" name > + "/files/FileZilla_Client/" version > + "/FileZilla_" version "_src" ".tar.bz2")) > + (sha256 > + (base32 > + "1bacrl8lj90hqbh129hpbgqj78k1i84j83rkzn507jnykj4x8p9x")))) > + (build-system gnu-build-system) > + (native-inputs > + `(("gettext" ,gettext-minimal) > + ("pkg-config" ,pkg-config) > + ("pugixml" ,pugixml) > + ("xdg-utils" ,xdg-utils))) > + (inputs > + `(("dbus" ,dbus) > + ("gnutls" ,gnutls) > + ("gtk+" ,gtk+) > + ("libfilezilla" ,libfilezilla) > + ("libidn" ,libidn) > + ("nettle" ,nettle) > + ("sqlite" ,sqlite) > + ("wxwidgets" ,wxwidgets))) > + (home-page "https://filezilla-project.org") > + (synopsis "Full-featured graphical FTP/FTPS/SFTP client") > + (description > + "Filezilla client supports FTP, FTP over SSL/TLS (FTPS), > +SSH File Transfer Protocol (SFTP), HTTP/1.1, SOCKS5, FTP-Proxy, IPv6 > +and others features such as bookmarks, drag and drop, filename filters, > +directory comparison and more.") > + (license gpl3+) Again, I'm under the impression that this should rather be gpl2+. I'd be happy to be proven wrong otherwise! > + (properties '((upstream-name . "FileZilla"))))) Otherwise LGTM (haven't tested though). Maxim --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJ9WGpPiQCFQyn/CfEmDkZILmNWIFAlihG70ACgkQEmDkZILm NWIpIg//ct4fRBJGSOemovuRtdNdw8sg7O1k9Yvb3TXS9YcIb9UQn5ox6M/hmpBB ufbT0x095jGHirz5SkTzFr/1zUfK+Le29rAxYoK8IwqKMGN+nozsqQ3njuMYbIdX nCPv6BYvIgxEeyN9LoAygyNARWUwFdQLsPxsDIGeFHM+5GvKy7b88nDUj33QMjv5 Lia8k56ATckIkzQr30LEBEA5RSZV5ZrD5II9UGmDlFZdSmnMVstRJp95tIccsPtH X5E+RGmCMu+PlxT3Vb8xm2qjMcbWrvz+bpjcDmcwOgvS7u/9bmfUcMK+yjECa6Ho CWrMF20IkYshVkZQNEpy9NX/9HqZpRMcAu8NakyzojBxh76pUQqDrosTviIEvign qljRKhGy1yv44Mq00hVH/8+UAlywROSUC5Xu11CXatL61S2jCPnaV3ZSpW6xDj5a py159GnQcCbM1W9QKD79o7fXuWAzIGxu9IphneXimEC8e8qs/j2OUJpuseU9hX0h 7se7AyLp35+Htj3xzec+88qDbl0qadh7g1sZPgCetuFxatTg9DoSaCZZlH95PW+z ILFDzHxL2JWEAAp6kmgpR3Xl+OSg6ClCAqB4n/rV/TrcMbx1YBfMer6iEo6o08ns NyKPUbrkE4gJMEW8vTevIesk4sxCxKO34HZGT3SdPi3y/KJwPhM= =JSEx -----END PGP SIGNATURE----- --=-=-=--