unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: 01/02: gnu: git: Enable tests.
       [not found] ` <20170803231845.5687A20445@vcs0.savannah.gnu.org>
@ 2017-08-13 20:44   ` Mark H Weaver
  2017-08-14 19:45     ` Marius Bakke
  0 siblings, 1 reply; 2+ messages in thread
From: Mark H Weaver @ 2017-08-13 20:44 UTC (permalink / raw)
  To: Marius Bakke; +Cc: guix-devel

Hi Marius,

mbakke@fastmail.com (Marius Bakke) writes:

> mbakke pushed a commit to branch master
> in repository guix.
>
> commit c9f4f56b24801718d89c2520bec08867516e1371
> Author: Marius Bakke <mbakke@fastmail.com>
> Date:   Thu Aug 3 23:02:02 2017 +0200
>
>     gnu: git: Enable tests.
>     
>     * gnu/packages/version-control.scm (git)[arguments]: Remove #:tests?. Add
>     'patch-tests' phase.

Thanks for this, but it broke git-2.10.3 on all platforms.  There are
still some failing tests on that older version.

  https://hydra.gnu.org/job/gnu/master/git-2.10.3.x86_64-linux
  https://hydra.gnu.org/job/gnu/master/git-2.10.3.i686-linux
  https://hydra.gnu.org/job/gnu/master/git-2.10.3.armhf-linux

Can you take a look?

      Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: 01/02: gnu: git: Enable tests.
  2017-08-13 20:44   ` 01/02: gnu: git: Enable tests Mark H Weaver
@ 2017-08-14 19:45     ` Marius Bakke
  0 siblings, 0 replies; 2+ messages in thread
From: Marius Bakke @ 2017-08-14 19:45 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]

Mark H Weaver <mhw@netris.org> writes:

> Hi Marius,
>
> mbakke@fastmail.com (Marius Bakke) writes:
>
>> mbakke pushed a commit to branch master
>> in repository guix.
>>
>> commit c9f4f56b24801718d89c2520bec08867516e1371
>> Author: Marius Bakke <mbakke@fastmail.com>
>> Date:   Thu Aug 3 23:02:02 2017 +0200
>>
>>     gnu: git: Enable tests.
>>     
>>     * gnu/packages/version-control.scm (git)[arguments]: Remove #:tests?. Add
>>     'patch-tests' phase.
>
> Thanks for this, but it broke git-2.10.3 on all platforms.  There are
> still some failing tests on that older version.
>
>   https://hydra.gnu.org/job/gnu/master/git-2.10.3.x86_64-linux
>   https://hydra.gnu.org/job/gnu/master/git-2.10.3.i686-linux
>   https://hydra.gnu.org/job/gnu/master/git-2.10.3.armhf-linux
>
> Can you take a look?

The one dependent package of git@2.10 only uses the source tarball, so
it is not affected by this failure. However I disabled tests regardless
to reduce stress on the build slaves.

Also updated it to 2.10.4 to fix the recent git CVE. Sorry for squased
commit, the broken indentation made it difficult to split up.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-08-14 19:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20170803231844.13647.4695@vcs0.savannah.gnu.org>
     [not found] ` <20170803231845.5687A20445@vcs0.savannah.gnu.org>
2017-08-13 20:44   ` 01/02: gnu: git: Enable tests Mark H Weaver
2017-08-14 19:45     ` Marius Bakke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).