From: Marius Bakke <mbakke@fastmail.com>
To: Alex Vong <alexvong1995@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: Fetching patches as origins instead of copying them into the Guix Git repo
Date: Mon, 04 Sep 2017 20:47:16 +0200 [thread overview]
Message-ID: <87o9qqjo7f.fsf@fastmail.com> (raw)
In-Reply-To: <87tw0l3u43.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]
Alex Vong <alexvong1995@gmail.com> writes:
> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Leo Famulari <leo@famulari.name> writes:
>>
>>> On Thu, Aug 31, 2017 at 09:52:49PM +0200, Marius Bakke wrote:
>>>> Side note: I think we should start adding patches as origins instead of
>>>> copying them wholesale, to try and keep the git repository slim.
>>>
>>> We should make a git-minimal package for things like this, or use
>>> guile-git / libgit2. Git itself is a very "heavy" package.
>>
>> No, I mean adding patches like this:
>>
>> (define %CVE-1970-0001.patch
>> (origin
>> (method url-fetch)
>> (uri "https://example.com/CVE-2017-0001.patch")
>> (sha256
>> (base32
>> "12c60iwxyc3rj6ih06a1g80vmkf8khvhm44xr9va4h21b74v8f5k"))))
>>
>> (package
>> (...
>> (patches (list (search-patch "guix-specific-stuff.patch")
>> %CVE-1970-0001.patch)))
>>
>> That only requires the built-in guix downloader.
>
> Are you suggesting we should download the patch directly from upstream
> or security advisory if they provide it and fall back to copying if they
> don't?
Yes, indeed; sorry for the crude explanation. Fetching instead of
copying serves two purposes: saves size in the guix repository, and
removes the need to verify patches manually as you only have to trust
their origin.
I sent an example here: <https://bugs.gnu.org/28330#11>.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-09-04 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87inh5uqpd.fsf@gmail.com>
[not found] ` <87inh4lw7y.fsf@fastmail.com>
[not found] ` <87y3q0ow9h.fsf@gmail.com>
[not found] ` <87k21jjyzy.fsf@fastmail.com>
2017-08-31 21:38 ` Fetching patches as origins instead of copying them into the Guix Git repo Leo Famulari
2017-08-31 21:52 ` Marius Bakke
2017-09-01 9:58 ` ng0
2017-09-01 10:03 ` ng0
2017-09-01 19:50 ` Leo Famulari
2017-09-02 17:09 ` Alex Vong
2017-09-04 18:47 ` Marius Bakke [this message]
2017-09-02 20:55 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9qqjo7f.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=alexvong1995@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).