From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: Status of Submitted Patches
Date: Thu, 24 May 2018 22:00:21 +0200
Message-ID: <87o9h4bz8q.fsf@elephly.net>
References: <8ea5d026-fab9-7b12-198e-610ad7743cb2@swecha.net>
	<871sfxev9w.fsf@elephly.net>
	<7626275c-3eee-bb05-ab9d-4c88ec6f0329@swecha.net>
	<87r2nvjte6.fsf@elephly.net>
	<5ab51417-b635-9725-9f48-3bc3f9b61fdf@swecha.net>
	<87tvsko2wd.fsf@elephly.net>
	<7290013c-990d-3f7d-d8db-38e090ed766a@swecha.net>
	<87zi28kt82.fsf@elephly.net>
	<8573e97d-d107-cde6-cd17-35f4ef6d2de3@swecha.net>
	<87k1takumm.fsf@elephly.net> <87o9hycwl6.fsf@elephly.net>
	<aff2d5c9-b497-6ead-3bb7-e7d7abf0d00a@swecha.net>
	<87r2mhdeap.fsf@elephly.net>
	<618c131c-6ba6-e525-aefc-72acca1c910f@swecha.net>
	<87a7suwtp7.fsf@elephly.net>
	<149bfb8c-22b5-797d-e88a-ca4077b0a4cc@swecha.net>
	<87d0xmok8e.fsf@elephly.net>
	<3a887aae-93f5-7e70-c8af-9bf4b4d17cb4@swecha.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57088)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1fLwQI-0008Ap-6l
	for guix-devel@gnu.org; Thu, 24 May 2018 16:01:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1fLwQH-0003By-JP
	for guix-devel@gnu.org; Thu, 24 May 2018 16:01:18 -0400
In-reply-to: <3a887aae-93f5-7e70-c8af-9bf4b4d17cb4@swecha.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Sahithi <sahi@swecha.net>
Cc: guix-devel@gnu.org


Hi Sahithi,

>> Another note about style: I think it would be better to use
>> =E2=80=9Calist->hash-table=E2=80=9D instead of =E2=80=9Cmake-hash-table=
=E2=80=9D followed by repeated
>> modifications to the hash table with =E2=80=9Chashq-set!=E2=80=9D.  We p=
refer to avoid
>> mutation of values when possible.
>
> I have made all necessary modifications. Can please review it once.

Thanks, this looks fine.
You don=E2=80=99t need (srfi srfi-13) for =E2=80=9Cstring-join=E2=80=9D.

>> Regarding copyright headers: please make sure to also add a copyright
>> line for yourself and a copyright line from the file of guile-colorize
>> to =E2=80=9C(guix ui)=E2=80=9D.
>>
>> When you=E2=80=99re done with these changes, please make a local commit =
and send
>> the output of =E2=80=9Cgit format-patch -1=E2=80=9D.
>
>
> I will proceed further once it is reviewed. :)

Please proceed with the patch.  I=E2=80=99d like us to make progress a litt=
le
more quickly going forward.

Thanks!

--
Ricardo