From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: [PATCH] download: Support 'https_proxy'.
Date: Mon, 13 May 2019 10:39:09 +0200
Message-ID: <87o946u4sy.fsf@gnu.org>
References: <874l62s88b.fsf@member.fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:58436)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1hQ6UO-0000aL-LL
	for guix-devel@gnu.org; Mon, 13 May 2019 04:39:17 -0400
In-Reply-To: <874l62s88b.fsf@member.fsf.org> (=?utf-8?B?IuWui+aWh+atpiIn?=
	=?utf-8?B?cw==?= message of "Fri, 10 May 2019 22:19:00 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@member.fsf.org>
Cc: guix-devel@gnu.org

Hi!

iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis:

> Hello, this patch add 'https_proxy' to 'guix download' (and guix-daemon
> if we update guix?):

Neat!

> From 424da6e43ba9c928403e3fd9b42e75d0fe90fc23 Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?=3DE5=3DAE=3D8B=3DE6=3D96=3D87=3DE6=3DAD=3DA6?=3D <iyzs=
ong@member.fsf.org>
> Date: Fri, 10 May 2019 21:27:40 +0800
> Subject: [PATCH] download: Support 'https_proxy'.
>
> * guix/build/download.scm (setup-http-tunnel): New procedure.
> (open-connection-for-uri): Honor the 'https_proxy' environment variable.

[...]

> +(define (setup-http-tunnel port uri)
> +  "Establish a tunnel to the destination server of URI."

Maybe =E2=80=9CEstablish over PORT an HTTP tunnel to the destination server=
 of
URI.=E2=80=9D?

Otherwise LGTM!

> Some problems and questions:
>=20
> - It assumes =E2=80=98https_proxy=E2=80=99 is =E2=80=98http://PROXY-SERVE=
R:PORT=E2=80=99, if the scheme
>   part is missing, it fail.

That=E2=80=99s already the case with =E2=80=98http_proxy=E2=80=99.

It seems that other tools can happily deal with the lack of a URI
scheme, so perhaps in a subsequent patch we should add code to
automatically add a URI scheme when it=E2=80=99s missing?

> - It fails some servers (eg: www.google.com) for me while curl works...

For www.google.com it fails even without =E2=80=98https_proxy=E2=80=99, so =
that=E2=80=99s OK.
:-)

> - I think this should go into guile=E2=80=99s =E2=80=98(web client)=E2=80=
=99 module?

Yes!  Once we=E2=80=99ve committed it Guix, it=E2=80=99d be great if you co=
uld a similar
patch to bug-guile@gnu.org.

Thank you!

Ludo=E2=80=99.