From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Nieuwenhuizen Subject: Re: wip-postfix Date: Tue, 17 Mar 2020 09:02:12 +0100 Message-ID: <87o8svh0jf.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:56038) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jE7BB-0002jl-D6 for guix-devel@gnu.org; Tue, 17 Mar 2020 04:02:30 -0400 In-Reply-To: (=?utf-8?Q?=22G=C3=A1bor?= Boskovits"'s message of "Fri, 7 Feb 2020 14:54:16 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: =?utf-8?Q?G=C3=A1bor?= Boskovits Cc: Guix-devel --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable G=C3=A1bor Boskovits writes: Hello G=C3=A1bor, > I've just pushed my work on postfix as a new wip-postfix branch. That's great! Yesterday I finally found some time to look at it. > Current status: > Service starts fine. Some warnings are sent on startup, telling that > some coreutils stuff is not found. No testing was done as of now. I fixed that, see attched patch. > Feedback welcome. I found mail delivery not to work, out of the box (using attached config). When I start a vm like so: sed -e 's,-append ",-append "console=3DttyS0 ,' $(./pre-inst-env guix s= ystem vm gnu/system/examples/postfix.tmpl) > rvm.shn sh rvm.sh -nographic -m 2G -net nic -net user,hostfwd=3Dtcp::10022-:222= 2,hostfwd=3Dtcp::10025-:25 it does not work for me; I get --8<---------------cut here---------------start------------->8--- $ telnet localhost 10025 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. 220 komputilo.localdomain ESMTP Postfix mail from: root mail from: root 250 2.1.0 Ok rcpt to: alice rcpt to: alice 451 4.3.0 : Temporary lookup failure data data 554 5.5.1 Error: no valid recipients --8<---------------cut here---------------end--------------->8--- When I hack around and create /etc/ailases.db, it works. It looks like most everything is installed in a single, flat directory /gnu/store/pyv0rpd6zs0m2i482cb8qxd6mhf5b47z-postfix-minimal-3.4.8 executables, copies of readmes, (unused?) config files (main.cf, aliases)? Anyhow, this is a great start; next Mailman? Greetings, janneke --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-postfix-minimal-Fix-startup-warnings.patch Content-Transfer-Encoding: quoted-printable >From 062afde1f7aa335f3be5e1074187a6dd0d33614b Mon Sep 17 00:00:00 2001 From: Jan Nieuwenhuizen Date: Tue, 17 Mar 2020 08:37:32 +0100 Subject: [PATCH] gnu: postfix-minimal: Fix startup warnings. This avoids kind of funny replacements like these of `rm' find -prune -perm -020 =3D> find -prune -pe/gnu/store/zibwkb5xavnv6z3gzknfqjsxb9b0izh0-coreutils-8.= 31/bin/rm -020 * gnu/packages/mail.scm (postfix-minimal)[phases]: Set PATH rather than substituting individual commands. --- gnu/packages/mail.scm | 28 +++++++++++++++++++--------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index 2cf1640200..287da82d55 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -30,6 +30,7 @@ ;;; Copyright =C2=A9 2018, 2019, 2020 Ricardo Wurmus ;;; Copyright =C2=A9 2019 Tanguy Le Carrour ;;; Copyright =C2=A9 2020 Brant Gardner +;;; Copyright =C2=A9 2020 Jan (janneke) Nieuwenhuizen ;;; ;;; This file is part of GNU Guix. ;;; @@ -3145,7 +3146,10 @@ Atom feeds or HTML archives.") "0hw9kbr05qdzvfqhxi4dp4n3s9xvdh0gr0la08a4bip06ybl4pcd")))) (build-system gnu-build-system) (arguments - '(#:phases + '(#:modules ((srfi srfi-26) + (guix build utils) + (guix build gnu-build-system)) + #:phases (modify-phases %standard-phases (add-before 'build 'patch-/bin/sh (lambda _ @@ -3177,14 +3181,20 @@ Atom feeds or HTML archives.") (lambda _ (invoke "make" "makefiles" "pie=3Dyes" "dynamicmaps=3Dyes"))) (add-before 'install 'fix-postfix-scripts-path - (lambda _ - (for-each - (lambda (command) - (substitute* '("postfix-install" "conf/post-install" "conf= /postfix-script") - (((string-append command " ")) (string-append (which com= mand) " ")))) - '("awk" "chmod" "chown" "chgrp" "cp" "find" "ln" "mkdir" "mv= " "rm" "sed" - "sleep" "sort" "touch" "uname")) - #t)) + (lambda* (#:key inputs #:allow-other-keys) + (let ((path (string-join + (map (compose (cute string-append <> "/bin") + (cute assoc-ref inputs <>)) + '("bash" "coreutils" "findutils" "gawk" "gr= ep" + "sed")) + ":"))) + (substitute* '("postfix-install" + "conf/post-install" + "conf/postfix-script") + (("^SHELL=3D/bin/sh") + (string-append "PATH=3D" path "\n" + "SHELL=3D" (assoc-ref inputs "bash") "/bi= n/sh"))) + #t))) (add-before 'install 'configure-install (lambda* (#:key outputs #:allow-other-keys) (let ((out (assoc-ref outputs "out"))) --=20 2.24.0 --=-=-= Content-Type: application/octet-stream Content-Disposition: attachment; filename=postfix.tmpl Content-Transfer-Encoding: base64 OzsgVGhpcyBpcyBhbiBvcGVyYXRpbmcgc3lzdGVtIGNvbmZpZ3VyYXRpb24gdGVtcGxhdGUKOzsg Zm9yIGEgImJhcmUgYm9uZXMiIHNldHVwLCB3aXRoIG5vIFgxMSBkaXNwbGF5IHNlcnZlci4KCih1 c2UtbW9kdWxlcyAoZ251KSkKKHVzZS1zZXJ2aWNlLW1vZHVsZXMgbWFpbCBuZXR3b3JraW5nIHNz aCkKKHVzZS1wYWNrYWdlLW1vZHVsZXMgc2NyZWVuKQoKKG9wZXJhdGluZy1zeXN0ZW0KICAoaG9z dC1uYW1lICJrb21wdXRpbG8iKQogICh0aW1lem9uZSAiRXVyb3BlL0JlcmxpbiIpCiAgKGxvY2Fs ZSAiZW5fVVMudXRmOCIpCgogIDs7IEJvb3QgaW4gImxlZ2FjeSIgQklPUyBtb2RlLCBhc3N1bWlu ZyAvZGV2L3NkWCBpcyB0aGUKICA7OyB0YXJnZXQgaGFyZCBkaXNrLCBhbmQgIm15LXJvb3QiIGlz IHRoZSBsYWJlbCBvZiB0aGUgdGFyZ2V0CiAgOzsgcm9vdCBmaWxlIHN5c3RlbS4KICAoYm9vdGxv YWRlciAoYm9vdGxvYWRlci1jb25maWd1cmF0aW9uCiAgICAgICAgICAgICAgICAoYm9vdGxvYWRl ciBncnViLWJvb3Rsb2FkZXIpCiAgICAgICAgICAgICAgICAodGFyZ2V0ICIvZGV2L3NkWCIpKSkK ICAoZmlsZS1zeXN0ZW1zIChjb25zIChmaWxlLXN5c3RlbQogICAgICAgICAgICAgICAgICAgICAg ICAoZGV2aWNlIChmaWxlLXN5c3RlbS1sYWJlbCAibXktcm9vdCIpKQogICAgICAgICAgICAgICAg ICAgICAgICAobW91bnQtcG9pbnQgIi8iKQogICAgICAgICAgICAgICAgICAgICAgICAodHlwZSAi ZXh0NCIpKQogICAgICAgICAgICAgICAgICAgICAgJWJhc2UtZmlsZS1zeXN0ZW1zKSkKCiAgOzsg VGhpcyBpcyB3aGVyZSB1c2VyIGFjY291bnRzIGFyZSBzcGVjaWZpZWQuICBUaGUgInJvb3QiCiAg OzsgYWNjb3VudCBpcyBpbXBsaWNpdCwgYW5kIGlzIGluaXRpYWxseSBjcmVhdGVkIHdpdGggdGhl CiAgOzsgZW1wdHkgcGFzc3dvcmQuCiAgKHVzZXJzIChjb25zICh1c2VyLWFjY291bnQKICAgICAg ICAgICAgICAgIChuYW1lICJhbGljZSIpCiAgICAgICAgICAgICAgICAoY29tbWVudCAiQm9iJ3Mg c2lzdGVyIikKICAgICAgICAgICAgICAgIChncm91cCAidXNlcnMiKQoKICAgICAgICAgICAgICAg IDs7IEFkZGluZyB0aGUgYWNjb3VudCB0byB0aGUgIndoZWVsIiBncm91cAogICAgICAgICAgICAg ICAgOzsgbWFrZXMgaXQgYSBzdWRvZXIuICBBZGRpbmcgaXQgdG8gImF1ZGlvIgogICAgICAgICAg ICAgICAgOzsgYW5kICJ2aWRlbyIgYWxsb3dzIHRoZSB1c2VyIHRvIHBsYXkgc291bmQKICAgICAg ICAgICAgICAgIDs7IGFuZCBhY2Nlc3MgdGhlIHdlYmNhbS4KICAgICAgICAgICAgICAgIChzdXBw bGVtZW50YXJ5LWdyb3VwcyAnKCJ3aGVlbCIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICJhdWRpbyIgInZpZGVvIikpKQogICAgICAgICAgICAgICAlYmFzZS11c2VyLWFj Y291bnRzKSkKCiAgOzsgR2xvYmFsbHktaW5zdGFsbGVkIHBhY2thZ2VzLgogIChwYWNrYWdlcyAo Y29ucyBzY3JlZW4gJWJhc2UtcGFja2FnZXMpKQoKICA7OyBBZGQgc2VydmljZXMgdG8gdGhlIGJh c2VsaW5lOiBhIERIQ1AgY2xpZW50IGFuZAogIDs7IGFuIFNTSCBzZXJ2ZXIuCiAgKHNlcnZpY2Vz IChhcHBlbmQgKGxpc3QgKHNlcnZpY2UgZGhjcC1jbGllbnQtc2VydmljZS10eXBlKQogICAgICAg ICAgICAgICAgICAgICAgICAgIChzZXJ2aWNlIG9wZW5zc2gtc2VydmljZS10eXBlCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKG9wZW5zc2gtY29uZmlndXJhdGlvbgogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAocG9ydC1udW1iZXIgMjIyMikpKQogICAgICAg ICAgICAgICAgICAgICAgICAgIChzZXJ2aWNlIHBvc3RmaXgtc2VydmljZS10eXBlKSkKICAgICAg ICAgICAgICAgICAgICAlYmFzZS1zZXJ2aWNlcykpKQo= --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com --=-=-=--