From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oPOjHWFlFWB/VwAA0tVLHw (envelope-from ) for ; Sat, 30 Jan 2021 13:55:45 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EJlRGWFlFWCpfQAAbx9fmQ (envelope-from ) for ; Sat, 30 Jan 2021 13:55:45 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C5AFA94030E for ; Sat, 30 Jan 2021 13:55:44 +0000 (UTC) Received: from localhost ([::1]:51366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5qj1-0000jF-QO for larch@yhetil.org; Sat, 30 Jan 2021 08:55:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5qit-0000iX-Bt for guix-devel@gnu.org; Sat, 30 Jan 2021 08:55:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44533) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5qir-0006qc-UF; Sat, 30 Jan 2021 08:55:33 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35344 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l5qic-0005Oq-2h; Sat, 30 Jan 2021 08:55:31 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Pierre Neidhardt Subject: Re: bug#45919: [PATCH 0/8] Exporting a manifest and channels from a profile References: <20210116182957.31075-1-ludo@gnu.org> <87wnvyv7w6.fsf@gnu.org> <871re5t2lg.fsf@ambrevar.xyz> <874kizsk0z.fsf@ambrevar.xyz> Date: Sat, 30 Jan 2021 14:55:16 +0100 In-Reply-To: <874kizsk0z.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Fri, 29 Jan 2021 18:57:48 +0100") Message-ID: <87o8h6fs1n.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel , 45919@debbugs.gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.85 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: C5AFA94030E X-Spam-Score: -2.85 X-Migadu-Scanner: scn1.migadu.com X-TUID: JWT82Z/j84Pa Hi Pierre, Pierre Neidhardt skribis: > I just had a cursory look, and my main concern is that maybe exposing > commands is one more thing to learn for the user, and one more step to > run to get a simple file. > > Instead, what about doing what system profiles already do with > > /run/current-system/channels.scm > /run/current-system/configuration.scm > > and store the result of the proposed commands directly in > $PROFILE/channels.scm and $PROFILE/manifest-spec.scm, on each profile > upgrade? > > We could add a warning comment at the top, explaining the limitations of > these files (that it does not represent the profile faithfully). > > Thoughts? Here are practical issues that come to mind: =E2=80=A2 It would only work for newer profiles, created after the featur= e has been implemented (maybe that=E2=80=99s okay). =E2=80=A2 The generated files might use APIs that, in the meantime, got deprecated or changed somehow. This is in contrast with =E2=80=98--export-profile=E2=80=99, which interprets =E2=80=98manifest= =E2=80=99 (a versioned file format) and produces code that can use the API du jour. =E2=80=A2 One would still have to learn about these two files, and pick t= he right =E2=80=9Cmanifest=E2=80=9D file. =E2=80=A2 For users of =E2=80=98-m my-manifest.scm=E2=80=99, we would nee= d to store =E2=80=98my-manifest.scm=E2=80=99 as is instead of generating an approx= imation thereof. We already discussed these issues at length earlier. :-) Again, I agree that following what we do with /run/current-system would be nice, but the situation is different due to imperative operations. Hmm, needs more thought=E2=80=A6 > Last, just a nit: what about listing the packages corresponding to the > commented commits next to them? For instance > > (list > ;; Note: these other commits were also used to install some of the packa= ges in this profile: > ;; "458cb25b9e7e7c954f468023abea2bebb5d8c75b" monolith obs calibre > ;; "4969b51d175497bfcc354c91803e9d70542b7113" 0ad augustus > ;; "3d85c3ec652feb22824f355538b51e6955ded361" nyxt > ;; ... > ;; "b76b1d3fb65fec98b96a2b4cfa984316dd956a29" tectonic > (channel > (name 'guix) > ... Would be nice. Thanks for your feedback! Ludo=E2=80=99.