From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ACryFRExGmKCXAAAgWs5BA (envelope-from ) for ; Sat, 26 Feb 2022 14:54:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8M9KExExGmIgWwAA9RJhRA (envelope-from ) for ; Sat, 26 Feb 2022 14:54:25 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0292E40D33 for ; Sat, 26 Feb 2022 14:54:25 +0100 (CET) Received: from localhost ([::1]:44248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNxWi-0008KR-3G for larch@yhetil.org; Sat, 26 Feb 2022 08:54:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNxTX-0006aQ-Fh for guix-devel@gnu.org; Sat, 26 Feb 2022 08:51:07 -0500 Received: from [2607:f8b0:4864:20::832] (port=36795 helo=mail-qt1-x832.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNxTV-0005Xe-2u for guix-devel@gnu.org; Sat, 26 Feb 2022 08:51:06 -0500 Received: by mail-qt1-x832.google.com with SMTP id f18so5068531qtb.3 for ; Sat, 26 Feb 2022 05:51:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=4hGW7CbNFsnvf20UhEjkMnP6ZUS5woECRQ2PiVikiyk=; b=dvYLVa481/joZ2kUjVnfnGRDauDINDnkvUDN25PeMmjMfgKXX1RbWhR992ayP4i1dm SVDLnS+/YUqznuiDkuaPxVJWhEvDUxrvTb2pPlK03IOEPu/kGNlypsBwEIWEsRme0xS7 spgKQ6fLM/eGTatsO7knIRpqVUEqfG9MU/3zUd4jk00ZnltR7pOc2povqLbTlt4/+Q6H alTu1u5G1kV8glsjb3oHxeBA0VDle+jqV813icdCXxSu2oD1418reZYdyq4ES3cQUE7L moiTFzj7h7MM/fu+9N0zqXa5KaROqiaN9SwLMXwiVKSAH7LQ12l0jDoY+/28BuNhbxnH z6Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=4hGW7CbNFsnvf20UhEjkMnP6ZUS5woECRQ2PiVikiyk=; b=yKgvLiMacC3hPKMxaBjBpXZHJFhcG3/dcFgz0pxBUsyy/8CFvndP4JWMFcE5IognVS SSj+CbPnzTh47Q4XVbV9mmvEg+Mvi8RHO3dCs7UUEQ6pBG5IegbN5jAvzbaMEi3YKem7 55RhZa/j00Sm/jbzvQTfhI3n+VWVBza30OZC9b+606D7snzR19VJBe0jTyWXbvgdwmKv lIfYUYNWk67OlakbuXt9qQ9+yUwebp+r8NAEV+zODBiZAqdsipUcD0Kje0GHpTB5lEF1 T6Zn/9XB31nP7Wie2yHyxPDNzvUhtYGnAuXhEQEOzx+IfeXi16tY8wThFysNWqVnGnHy TUPQ== X-Gm-Message-State: AOAM532QlZBgrew4xXBt5PlhkCBy4AaQrGQjwrb1deQSVhuIZeGC037D 9URqxHiNP7L2ZhLZ49so3nvVrJ3sYBoDgg== X-Google-Smtp-Source: ABdhPJz8JJnw42V4ddqqkcHIf0pbQCsvHkPr/aGoosGa19zmlrP610wURTmK/M6TzyAkEHn+KFPjYA== X-Received: by 2002:a05:622a:1187:b0:2de:6ffc:19f8 with SMTP id m7-20020a05622a118700b002de6ffc19f8mr10682368qtk.453.1645883463630; Sat, 26 Feb 2022 05:51:03 -0800 (PST) Received: from hurd (dsl-149-67.b2b2c.ca. [66.158.149.67]) by smtp.gmail.com with ESMTPSA id 22-20020ac85916000000b002d6844c51b9sm3276674qty.86.2022.02.26.05.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Feb 2022 05:51:03 -0800 (PST) From: Maxim Cournoyer To: Ricardo Wurmus Subject: Re: better error messages through assertions References: <87ilthoxvu.fsf@elephly.net> <875yp2zsgd.fsf@gmail.com> <87lexx7nv4.fsf@elephly.net> Date: Sat, 26 Feb 2022 08:51:02 -0500 In-Reply-To: <87lexx7nv4.fsf@elephly.net> (Ricardo Wurmus's message of "Sat, 26 Feb 2022 14:33:08 +0100") Message-ID: <87o82twxbt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::832 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::832; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x832.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645883665; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=4hGW7CbNFsnvf20UhEjkMnP6ZUS5woECRQ2PiVikiyk=; b=NA9V1Y4YpSjjPoRuKOVXKMOJFTzdXj/tkYoHDVRGJY9D2qKhIIxE12CKukUKd4lsyBnt59 6BR1t8LcHIDW1ixWq9MUylWMAFiKciSUvJTQempkDhgw0fFmKpW7EwNYZWn2oNd2AZRf7U L9ADR84kaIPGuhyPUr6NvxKV67WlNkMXgWR63UC8RNESAC8vxViXdQ9XTQDQqYIw/U3xrM O4Ad1NXQgsl1fdz2qsEi0Zh8beeluKWmpjn9cYtPq68ckjiapAOTlIvN9i6a0CVLNY5/j9 LKyubDFSyLRlFopDe8PIQixgtKX0vYkbYkLR+dXMgOrbvmEhqU+SF05UYpWEag== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645883665; a=rsa-sha256; cv=none; b=PUA6faoZLIEtGtfmtYKmBwgLgfKqsFNzP3zKbmEidsJ/4hBYMXqUgmUqr6Rec7RZ/qQNUT HrlGUWUuXbUMoPlgLHrxHJSXsX6OKzSjNamLsMNtZIJsSYmRBMs/TFuE+d0AwEgxoElo1P VlLAnISjT72n0YEzFal0Y6DkrOoyVLdsmgW8y5hA9TxskHmGeDaXIN8NeZLuRCJ2m7wtYs +0yji5FEw/jeddwFEenghFP3k2lcv64MxNoHE7+gDMPRxnBOYh/BVboRJmsPwIW0XjHiUN lWvUpw8MTKGPeXsWCNn6nQ6bssGhCAnYsMBY7aMU6jXaRjB9P+ilmBvglSEPZQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dvYLVa48; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.12 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dvYLVa48; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0292E40D33 X-Spam-Score: -6.12 X-Migadu-Scanner: scn0.migadu.com X-TUID: WJTib2xdPdRJ Hi Ricardo, Ricardo Wurmus writes: > Maxim Cournoyer writes: > >> I hear we now have "field sanitizers" on Guix records; without having >> dug the details, it seems to be we could add a predicate validating the >> input there? > > I don=E2=80=99t see how that would help here. In my example the service = values > themselves are all right. It=E2=80=99s a procedure acting on what it ass= umes is > a list of service values that fails. > > Record field validation would not have prevented that error. Thanks for explaining. For what it's worth, what you are proposing seems a sound improvement to me, so feel free to go ahead with patches! Thanks, Maxim