unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Marius Bakke <marius@gnu.org>
Cc: Christopher Baines <mail@cbaines.net>,  guix-devel@gnu.org
Subject: Re: 01/03: gnu: lld-as-ld-wrapper: Add version 15.
Date: Sat, 19 Nov 2022 20:30:17 -0500	[thread overview]
Message-ID: <87o7t22z12.fsf@gmail.com> (raw)
In-Reply-To: <87k03q1w8y.fsf@gnu.org> (Marius Bakke's message of "Sat, 19 Nov 2022 22:15:41 +0100")

Hi,

Marius Bakke <marius@gnu.org> writes:

> Christopher Baines <mail@cbaines.net> skriver:

[...]

>> I spotted this change when looking at [1] as the Guix Data Service is
>> failing at extracting a consistent derivation for lld-as-ld-wrapper@0.
>>
>> 1: https://qa.guix.gnu.org/issue/59367
>>
>> Maybe that could be viewed as a bug in the Guix Data Service, as it
>> assumes/wants packages to be unique by name and version (at least the
>> public/visible packages).
>>
>> But this is something raised by the linter also:
>>
>>   → ./pre-inst-env guix lint lld-as-ld-wrapper
>>   guix lint: warning: ambiguous package specification `lld-as-ld-wrapper'
>>   guix lint: warning: choosing lld-as-ld-wrapper@0 from gnu/packages/llvm.scm:1594:2
>>
>> Is there something that can be done about this, perhaps by using the lld
>> package version in the name or version for this package, or by hiding
>> this package?
>
> I think using the LLD version is sensible.  I made this change in
> cd9161372aa3ec9b8902385d5937d04e1868495c and also inherited the
> home-page and license fields.
>
> Maxim: please let me know if you this this was misguided!

No, it looks reasonable to me :-).

-- 
Thanks,
Maxim


  reply	other threads:[~2022-11-20  1:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166870906351.8449.8741107130024395258@vcs2.savannah.gnu.org>
     [not found] ` <20221117181744.1E709C0E4B9@vcs2.savannah.gnu.org>
2022-11-19 11:30   ` 01/03: gnu: lld-as-ld-wrapper: Add version 15 Christopher Baines
2022-11-19 21:15     ` Marius Bakke
2022-11-20  1:30       ` Maxim Cournoyer [this message]
2022-11-21 11:08       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7t22z12.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=mail@cbaines.net \
    --cc=marius@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).