From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 8dpPFPK3P2QgdAEASxT56A (envelope-from ) for ; Wed, 19 Apr 2023 11:44:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qBp/E/K3P2QH3AAA9RJhRA (envelope-from ) for ; Wed, 19 Apr 2023 11:44:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F049A9C67 for ; Wed, 19 Apr 2023 11:44:17 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pp4Ln-0006yc-2L; Wed, 19 Apr 2023 05:43:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pp4Lk-0006yG-SL for guix-devel@gnu.org; Wed, 19 Apr 2023 05:43:40 -0400 Received: from sender3-of-o57.zoho.com ([136.143.184.57]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pp4Lg-0002PS-Tm for guix-devel@gnu.org; Wed, 19 Apr 2023 05:43:39 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1681897411; cv=none; d=zohomail.com; s=zohoarc; b=anN5Z/1YDlGiSWUjlHlmnznzJ2yWcC0mY2DcxaLFedVpJnQNfeX4N28ymqYfd83QWGyzlWirkAm84pBLm1VW0N5R9ONlq9uo6z7PZM40EuihCpLUHlnXlZbozBVAiGcj7lzPvNy5vZyflKt4C8/ZBHCC3xPGYEgZ1b8VgNjQzxg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681897411; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=ILOmBiDYo4A04F+KDeVUxyGbyTMBknpIkyyN8lFw/Ok=; b=lL4FsQKJ7cUxGU21FnM/fDRcCFA+K49FgWEM2sO521FvW5H0+TPNgI7C7KxAS542fpzJc2RUZtrGbZQ4TJliUMJoGyVqhoOkvOIFFA4w6QgsBFFv7UqOPsqQGV8gb1iXk1iV1wA048spcfFUqXDlj1ZzFJ4SeLZMX/LZY7Rfsa8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1681897411; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=ILOmBiDYo4A04F+KDeVUxyGbyTMBknpIkyyN8lFw/Ok=; b=VlcEZA1oqyfyCutKZ0XIDz7sa/xZrjLBBj+HhCdacTnnV1REW78xwJ3gOuqAo7uc b3CuhVS6+ZxP+jH9aPDnYypVaNdLeoZV9BTU++H6+49QESMu6nCS/MlQteBjvL7WOFk j52XZGBpZYbR+S/gDh5cGNW58iTq5QBPnz8LsFNs= Received: from localhost (i5E862D7D.versanet.de [94.134.45.125]) by mx.zohomail.com with SMTPS id 1681897410386676.9016488569355; Wed, 19 Apr 2023 02:43:30 -0700 (PDT) References: <86fs8wjm1y.fsf@gmail.com> <87mt34qlmk.fsf@nicolasgoaziou.fr> User-agent: mu4e 1.10.2; emacs 28.2 From: Ricardo Wurmus To: Nicolas Goaziou Cc: Simon Tournier , Guix Devel Subject: Re: Question about packaging TexLive Date: Wed, 19 Apr 2023 11:36:46 +0200 In-reply-to: <87mt34qlmk.fsf@nicolasgoaziou.fr> Message-ID: <87o7nkqkap.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.184.57; envelope-from=rekado@elephly.net; helo=sender3-of-o57.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=2; s=key1; d=yhetil.org; t=1681897458; a=rsa-sha256; cv=pass; b=Fgv2Ysh4Zci43FEmb5xYIVYJKahuvKWzQIadDG9LQ8AGWdpfJ/zdJicpzACUso2nbowZ7T A214lidoee2iQF1qqNnDa42A8pP0UuaADgFVdI/2RoxPy2qqFU9IYMkWiPEblyp+IqYp0f fWnY+wlvLZ7f02egaKcfJCxYk0Ij/Q17K2mIDz63621w5r9yZEx/jAOpyMbT6JLbxIvnZP ngoFdnOLtZviFxCO4Wpur0Yr6tgZ9MMI6AESuPKGXW3O+WMXcPXIywajreZ4BnAVRvRda3 Ow6YbSsx8M7hr85j1LGFkk8mp821RAp+TgewfxBqJbQeR/HX3akJrhnmKb6pMA== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=VlcEZA1o; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681897458; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=ILOmBiDYo4A04F+KDeVUxyGbyTMBknpIkyyN8lFw/Ok=; b=ulDRC1EDGLw4Z83NfIYIfRisziKDMebg7fB9LVJKdLeFLkJx5wgIvpYjEwsjfz8aHppUNB CG2ogxvGOsNXaqwKXySgRe4M0aXVYQGNmX+tcPw7JLOnQRDoxXUr4vQWE4oi06/OAZYcMI N4tGf001mwqjcCD/G5XFYxK87SJUAh2jOVwSYtO5MeTYiErL37FJ2VFdygYnH+jQzr/6cN uHYvlNob8aO9dHZyBAxVWssPF/jXvq3+eWAxTTcWG1L+weO3+3Fk4FoXNsHmI3VGh0wOrv 3uXL2Ekng4CgeZVLKiOL4vs8T7Oi1ZrF+Wi6oyDkt59SfunUK3pJQdfQY4DnoA== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -6.90 X-Spam-Score: -6.90 X-Migadu-Queue-Id: F049A9C67 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=VlcEZA1o; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-TUID: FPbypue2LMTx Nicolas Goaziou writes: > Hello, > > Simon Tournier writes: > >> Other said, any objection to go from this pattern: >> >> --8<---------------cut here---------------start------------->8--- >> (define-public texlive-foo >> (package >> (name "texlive-foo") >> (version (number->string %texlive-revision)) >> (source (origin >> (method svn-multi-fetch) >> (uri (svn-multi-reference >> (url (string-append "svn://www.tug.org/texlive/tags/" >> %texlive-tag "/Master/texmf-dist= ")) >> (locations '("/metafont/" >> "/fonts/source/public/modes/")) >> (revision %texlive-revision))) >> (file-name (string-append name "-" version "-checkout")) >> (sha256 >> (base32 >> "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"))= )) >> (build-system gnu-build-system) >> (arguments >> `(#:tests? #f ; no test target >> #:phases >> [...] >> --8<---------------cut here---------------end--------------->8--- >> >> >> to this pattern: >> >> --8<---------------cut here---------------start------------->8--- >> (define-public texlive-foo >> (package >> (inherit (simple-texlive-package >> "texlive-foo" >> (list "/tex/generic/foo") >> (base32 >> "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx") >> #:trivial? #t)) >> --8<---------------cut here---------------end--------------->8--- >> >> It is about ~35 packages, if I count correctly. >> >> WDYT? > > I think this is necessary but not sufficient. > > 1. "#:trivial? #t" means we're giving up generating ".sty" files from > source; Trivial should only ever be used for packages where there aren=E2=80=99t any sources to build from. > 2. Some affected packages are also missing propagated inputs (e.g., > texlive-latex-graphics for texlive-latex-fncychap); Correct. The old importer didn=E2=80=99t know about dependencies. The new= er importer uses tlpdb to get a list of dependencies. > 3. Some affected package also need to be renamed > (texlive-latex-fncychap, texlive-latex-framed). > > AFAIU, this changes will probably ease time travelling, but the massive > rebuild it will entail will have to be repeated for the other steps. > > So maybe we could do every step above in one go? Using svn-multi-reference is the old way; we should be using simple-texlive-package for all packages wherever possible. Yes, we still have a lot of old package names. They all should be renamed to the new style. All packages must be checked for completeness. All new packages I=E2=80=99= ve added have been checked. All old packages must be checked before renaming them. The way to check them is to build them and then check the outputs with something like this: --8<---------------cut here---------------start------------->8--- ,use (guix import texlive) ,pp (files-differ? "/gnu/store/=E2=80=A6-texlive-amsfonts-fixed-59745/share= /" "amsfonts") --8<---------------cut here---------------end--------------->8--- This compares outputs with tlpdb. Note that simple-texlive-package is far from perfect. We have many tex packages that require excessive workarounds to ensure that files end up in the correct location and that superfluous files are removed. simple-texlive-package should eventually take care of all of this, but I haven=E2=80=99t been able to make time to work on it. All this work should be done on a separate feature branch. --=20 Ricardo