unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: branch master updated: gnu: sbcl: fix build on riscv64-linux.
Date: Wed, 07 Jun 2023 12:05:48 +0100	[thread overview]
Message-ID: <87o7lr1q9i.fsf@cbaines.net> (raw)
In-Reply-To: <168613176184.20968.13937818067907883384@vcs2.savannah.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1511 bytes --]


guix-commits@gnu.org writes:

> This is an automated email from the git hooks/post-receive script.
>
> efraim pushed a commit to branch master
> in repository guix.
>
> The following commit(s) were added to refs/heads/master by this push:
>      new 2a6d2fc1d8 gnu: sbcl: fix build on riscv64-linux.
> 2a6d2fc1d8 is described below
>
> commit 2a6d2fc1d8e3434e283d6d2e559529b41a242fea
> Author: Efraim Flashner <efraim@flashner.co.il>
> AuthorDate: Wed Jun 7 09:55:35 2023 +0300
>
>     gnu: sbcl: fix build on riscv64-linux.
>
>     * gnu/packages/patches/sbcl-riscv-Make-contribs-build-again.patch: New
>     file.
>     * gnu/local.mk(dist_patch_DATA): register it.
>     * gnu/packages/lisp.scm (sbcl): [source]<patches>: Use it here.
> ---
>  gnu/local.mk                                       |  1 +
>  gnu/packages/lisp.scm                              |  3 +
>  .../sbcl-riscv-Make-contribs-build-again.patch     | 71 ++++++++++++++++++++++
>  3 files changed, 75 insertions(+)

Did this change need to go straight to master?

→ guix refresh -l sbcl
Building the following 314 packages would ensure 1615 dependent packages are rebuilt: ...

To me that says to be that this would be appropriate for staging [1].

1: https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html#index-rebuild-scheduling-strategy

Maybe this would be OK if the patch was applied in such a way that it
only affects riscv64-linux, but it isn't, so this affects all systems.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

           reply	other threads:[~2023-06-07 11:11 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <168613176184.20968.13937818067907883384@vcs2.savannah.gnu.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7lr1q9i.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).