From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id WCdEHsEFIGUFXgAA9RJhRA:P1 (envelope-from ) for ; Fri, 06 Oct 2023 15:04:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WCdEHsEFIGUFXgAA9RJhRA (envelope-from ) for ; Fri, 06 Oct 2023 15:04:01 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 34AB2405CE for ; Fri, 6 Oct 2023 15:04:01 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="TjN/pmYr"; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696597441; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=NXX3uxdZv8kx1UsIs5fYBlUU66IKLlE8ayM6/GnzRNs=; b=ILR8o5IowfX18vbdD1zR35LmFYW2BriIIKwTyG36sOemT1Pzr2kmSQ7dgYhfcSYxPb6Vi6 LB6TMvR+G5YnaUBAw+LGazOwN5PCG0g4sEmx3BSIB9UrZuylZ2FSk4gTR3z8bXaidujCXG S8XVzcpWmvCBVw/9nHiBwb5b3y8+bcTJQPyBD/06bAjZICFN6nOmOlxxB0Xva+6ZOBP282 r2SfPi/OzEtQbOomDJQJ42FMBfwDdjJ1/snMH4AAwq9NniDwhRzdljwwB0Fdyauwi0/pDL YijzPDEH7Cf4VKMxxW2vEMYV1gSHVWbr6ZmiRuvncKEYLjXlhKTV45hL6EpMjQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696597441; a=rsa-sha256; cv=none; b=rfNLzumhy8GHaxRi+jKEJtC1RqXxLN8Fo19murFbsUbcuRFA5N9mtIf7FdFaXUGQV/RwmF XsMvCrTMN7Tqbz9xf5ynGeLe5a9dAV9+JYP4uoTU6tg2B25SwkfJJbSTBX/LShg1zcoVgP t2rzVh22Zuc21YdO1E9kyBt0a8dIHpldr6I/ZfB6OxDj14D6wXQM+FvR8pJky4o4RL9VzU F0uVUE0sbXq7lY9ME7xHPFBwsyK2wA8OLFbEz4IRfbqOgQ+8xVp2+dly8VVkn/NBD0om5w XqWw0kVNPmsqB3BaK4EQbKmeTthj/rTrNISwGZvbYp6oBaGZd78vss14SmM/yw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="TjN/pmYr"; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qokUL-0004Nq-Mb; Fri, 06 Oct 2023 09:03:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qokUG-0004Nf-Ai for guix-devel@gnu.org; Fri, 06 Oct 2023 09:03:24 -0400 Received: from mail-qv1-xf2a.google.com ([2607:f8b0:4864:20::f2a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qokUE-0006IU-P3 for guix-devel@gnu.org; Fri, 06 Oct 2023 09:03:24 -0400 Received: by mail-qv1-xf2a.google.com with SMTP id 6a1803df08f44-65b2463d651so11862406d6.3 for ; Fri, 06 Oct 2023 06:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696597401; x=1697202201; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=NXX3uxdZv8kx1UsIs5fYBlUU66IKLlE8ayM6/GnzRNs=; b=TjN/pmYrZpCjUIdAxNB2p2GxOn15MvFMC2DqjKQWItbAUb+/XGl9lz3fiXfozpaP+c 2pXlGqvk2H0sDJhxXpqxJGimvClXCaNt9HQugJfwT77sFGzOE5tlUu3oEtrPpzaQmMiu SILxMMic3oIaji2xtSqyqu7QSDRPErIAirghmT+dhdzcKso1Lt3hpPvcnbY/q7R2YqQF FbktUpTp/GvZUUvPKEx9M7su5WApQmjl4ckV1vYbwVp54Bkalz8vp21FJ51ukOijt71T 3LeTm7Pl8rihdBGjTLJQogmyXxxDum/6XKD1uaxlDdHVdJCGJ00jEIT5FFEd0ULqPnzc GQ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696597401; x=1697202201; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NXX3uxdZv8kx1UsIs5fYBlUU66IKLlE8ayM6/GnzRNs=; b=T1w3Hr0F6Itl4G+GBe0HRasJeLc7sL8mkUbEXfo2gi4TJ13nUOaFjaRilQFBZxxr0W c58Glf0afxN5i7eyJF7Wc1JHpYmI3Lfqo7BJjrdOwjhEIymeR2BWrs+sos/WXuDHpapW tO02ID11cwavXH+o12tIQ4+xCpI5hXRocgZpXnDJ17DeE58WrhktboxvHKCbYzV2BJLz Ua8xdiNel6T+Rqia37yuH7z1yywT4MYvFdA4/8xZbeRjLqNjuCGgWjq/WhpZRZi2ABV2 BMKcLmlJqclNUFafYy3PAW1FvvZgAiNsE62/fYXceV2Y6maU09pR1B24uCgrWCMjoa7P voEA== X-Gm-Message-State: AOJu0YwwG6kBu1SddkPa9Nm4SJBqKwhGnr6NbLMMFJP0cMTwX6OiQMn6 ThcGqsKy2OwOHYVKaOfmWYS9uqcYwk45Ag== X-Google-Smtp-Source: AGHT+IEOVXl+4sdRazjl15FOmLvqd8cYAqOn2qyOax2dFPXEFj2BLlkNDg+7lNebGscemxPHDY0P/Q== X-Received: by 2002:a0c:aa5b:0:b0:63c:fa7d:74ee with SMTP id e27-20020a0caa5b000000b0063cfa7d74eemr8332124qvb.50.1696597401342; Fri, 06 Oct 2023 06:03:21 -0700 (PDT) Received: from hurd (dsl-151-116.b2b2c.ca. [66.158.151.116]) by smtp.gmail.com with ESMTPSA id r2-20020a0ccc02000000b0065cfec43097sm1352369qvk.39.2023.10.06.06.03.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 06:03:20 -0700 (PDT) From: Maxim Cournoyer To: Munyoki Kilyungi Cc: jgart , guix-devel@gnu.org Subject: Re: IDEA: missing-tests-pypi-error? condition In-Reply-To: <87v8bkxgl3.fsf@saitama.mail-host-address-is-not-set> (Munyoki Kilyungi's message of "Fri, 06 Oct 2023 12:09:28 +0300") References: <41cf39960ed499205b21e677c872a29f@dismail.de> <87v8bkxgl3.fsf@saitama.mail-host-address-is-not-set> Date: Fri, 06 Oct 2023 09:03:18 -0400 Message-ID: <87o7hbkind.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::f2a; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf2a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -9.55 X-Migadu-Spam-Score: -9.55 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Queue-Id: 34AB2405CE X-TUID: PiR4qctynofW Hi, Munyoki Kilyungi writes: > "jgart" aliandika: > >> Hi Guixers, >> >> I was recently reviewing a patch by a contributor and was discussing the notion of preferring upstream to PyPI when tests are missing on PyPI. >> > What's the policy on this. Shouldn't we prefer > upstream over PyPI? Sometimes, PyPI versions lag > behind upstream versions. There's no written policy about it at this time, but I think it's common knowledge in Guix that we try hard to: 1. Unbundle dependencies (that one is documented) 2. Run test suites (that one isn't) We could hint at this globally in the contributing section, and perhaps expound with more specific details in the Python Modules contributing section, mentioning that when the PyPI source archive lacks tests, fetching from the git repository should be preferred. Another thing we could do is default to fetch from git for the Python importer. >> WDYT if we also signalled a special condition when there are missing tests in PyPI? >> > I posit that this should be the responsibility of > the contributor. Adding extra glue can add > unnecessary complexity. I think an error would help catching this situation; the gnu-build-system would fail running 'make check' when there is no check target for example, but in the Python world, running 'python setup.py test' often succeeds even 0 tests were run, which is easy to overlook. I'm not sure how easy it'd be to check for missing tests though. -- Thanks, Maxim