From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: gnu : add GNU Mig
Date: Thu, 20 Feb 2014 23:20:31 +0100
Message-ID: <87mwhll93k.fsf@gnu.org>
References: <CAFtzXzOhCjvHGHDBnTQCoWJJyepp2hOuL-OyCr6ZuOAu5eFJZA@mail.gmail.com>
	<87vbwc8i6y.fsf@gnu.org>
	<CAFtzXzMBcEt=nLEkRrkcbwtnnCG5j3S2McNCAg8GfrBAzLfx5A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47182)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WGbz0-00020w-Hq
	for guix-devel@gnu.org; Thu, 20 Feb 2014 17:20:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WGbys-0001Io-5g
	for guix-devel@gnu.org; Thu, 20 Feb 2014 17:20:42 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:56782)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1WGbyr-0001Hn-QC
	for guix-devel@gnu.org; Thu, 20 Feb 2014 17:20:33 -0500
In-Reply-To: <CAFtzXzMBcEt=nLEkRrkcbwtnnCG5j3S2McNCAg8GfrBAzLfx5A@mail.gmail.com>
	(Manolis Ragkousis's message of "Thu, 20 Feb 2014 13:45:05 +0000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix Development <guix-devel@gnu.org>

Manolis Ragkousis <manolis837@gmail.com> skribis:

> 1) Fixed the variable and package name to "mig"
> 2) Fixed the position of the backtick with M-x indent-region to be proper=
ly
> aligned
> 3) mig is not a binary but a script, but it still needs the build phase.
> You were right Ludo.
> 4) I wrapped the lines to ~75 chars
> 5) I took the description from the GNU mig website and make
> sync-descriptions doesn't say anything so I guess it's the right one.
>
> I hope I did everything right this time :-)

Yep, thanks! :-)

> +    (arguments
> +     `(#:configure-flags '("TARGET_CPPFLAGS=3D-I/include" "--build=3Di68=
6-pc-gnu")
> +       #:tests? #f))

I pushed it after removing #:configure-flags: the --build hack isn=E2=80=99t
needed here AFAICS, and TARGET_CPPFLAGS=3D-I/include is useless given that
we don=E2=80=99t have /include.

Also, when such non-obvious hacks are needed, it=E2=80=99s important to add=
 a
comment explaining why they are needed.

Thanks!

Ludo=E2=80=99.