Re: [PATCH 2/2] gnu: Add jrnl.

[ludo@gnu.org (Ludovic Courtès)]

Eric Bavier <ericbavier@gmail.com> skribis:

> From d2131f9ddbbac601d3915b815fa58bce05b5d663 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Mon, 30 Jun 2014 00:28:40 -0500
> Subject: [PATCH 2/2] gnu: Add jrnl.
>
> * gnu/packages/jrnl.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> * gnu/packages/python.scm (python-pycrypto, python-keyring, python-dateutil-2,
>   python-parsedatetime, python-tzlocal): New variables.
> * guix/licenses.scm (cc0): New variable.

OK, but could you make the addition of cc0 a separate commit?

> +    (home-page "http://maebert.github.io/jrnl/")
> +    (synopsis "Journal application")

Maybe “Note-taking and journal application”?  (I wasn’t sure what
“journal” meant here.)

> +    (license (x11-style "file://LICENSE"))))

AFAICS it is exactly the MIT/X11 license:

  https://github.com/maebert/jrnl/blob/master/LICENSE

Thus, could you change it ‘x11’?

(There was another one like this in the Behave patch, but I didn’t
check.)

> +    (synopsis
> +     "Extensions to the standard datetime module, available in Python 2.3+")

Remove “, available in Python 2.3+”.

OK to push with these changes.

Thanks!

Ludo’.